Ohad Basan has posted comments on this change. Change subject: ovirt-live: migrate ovirt live plugin to otopi ......................................................................
Patch Set 2: (3 inline comments) .................................................... File fedora/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/oliveconst.py Line 1: #!/bin/python oops I missed that will fix Line 2: Line 3: #OVIRT LIVE Line 4: Line 5: @util.export Line 15: class OLEnv(object): Line 16: ENABLE = 'OVESETUP_OL/enable' Line 17: Line 18: def CONFIGURE(self): Line 19: return 'OVESETUP_OL/configure' I have no need for live configuration in this plugin everything will be done automatically Line 20: Line 21: @osetupattrs( Line 22: answerfile=True, Line 23: summary=False, Line 22: answerfile=True, Line 23: summary=False, Line 24: ) Line 25: def ROOT_PASSWORD(self): Line 26: return 'OVESETUP_AIO/rootPassword' I don't :) Line 27: Line 28: LOCAL_DATA_CENTER = 'OVESETUP_AIO/localDataCenter' Line 29: LOCAL_CLUSTER = 'OVESETUP_AIO/localCluster' Line 30: LOCAL_HOST = 'OVESETUP_AIO/localHost' -- To view, visit http://gerrit.ovirt.org/17518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I703f64dc1183a6fe176d9d0352f93de381d906bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
