Sandro Bonazzola has posted comments on this change.
Change subject: ovirt-live: migrate ovirt live plugin to otopi
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
fedora/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py
Line 75: oliveconst.Stages.OL_COPY_ISO
Line 76: ],
Line 77: after=[osetupcons.Stages.AIO_CONFIG_VDSM]
Line 78: )
Line 79: def _createstorage(self):
Why do we need another data domain? Isn't the one created by all-in-one plugin
(vdsm._closeup) enough?
Line 80: import ovirtsdk.api
Line 81: from ovirtsdk.xml import params
Line 82:
Line 83: self._ovirtsdk_api = ovirtsdk.api
Line 122: oliveconst.Stages.OL_CREATE_VM,
Line 123: ],
Line 124: )
Line 125:
Line 126: def _copyiso(self):
I suggest to patch image_upload plugin for using an env variable instead of a
private attribute and add the needed iso files to that env having the upload
logic in a single place.
Line 127: self.logger.debug('Copying Iso Files')
Line 128: isoPattern = "/home/oVirtuser/oVirtLiveFiles/iso/*.iso"
Line 129: fileList = glob.glob(isoPattern)
Line 130: targetPath =
os.path.join(self.environment[osetupcons.ConfigEnv.ISO_DOMAIN_DEFAULT_NFS_MOUNT_POINT],
self.environment[osetupcons.ConfigEnv.ISO_DOMAIN_SD_UUID], "images",
"11111111-1111-1111-1111-111111111111")
--
To view, visit http://gerrit.ovirt.org/17518
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I703f64dc1183a6fe176d9d0352f93de381d906bb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
