Ofer Schreiber has posted comments on this change.

Change subject: WIP: packaging: setup: host rename
......................................................................


Patch Set 11: (12 inline comments)

First text pass

....................................................
Commit Message
Line 3: AuthorDate: 2013-07-28 16:04:03 +0300
Line 4: Commit:     Yedidyah Bar David <[email protected]>
Line 5: CommitDate: 2013-08-01 09:07:25 +0300
Line 6: 
Line 7: WIP: packaging: setup: host rename
Please add some description for this important feature
Line 8: 
Line 9: Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f


....................................................
File packaging/setup/bin/ovirt-engine-rename
Line 1: #!/bin/sh
Line 2: #
Line 3: # ovirt-engine-setup -- ovirt engine setup
s/setup/rename
Line 4: # Copyright (C) 2013 Red Hat, Inc.
Line 5: #
Line 6: # Licensed under the Apache License, Version 2.0 (the "License");
Line 7: # you may not use this file except in compliance with the License.


....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/engine.py
Line 1: 
Line 2: #
Line 3: # ovirt-engine-setup -- ovirt engine setup
same
Line 4: # Copyright (C) 2013 Red Hat, Inc.
Line 5: #
Line 6: # Licensed under the Apache License, Version 2.0 (the "License");
Line 7: # you may not use this file except in compliance with the License.


Line 20: """Misc plugin."""
Line 21: 
Line 22: 
Line 23: import gettext
Line 24: _ = lambda m: gettext.dgettext(message=m, domain='ovirt-engine-setup')
should this stay "setup"?
Line 25: 
Line 26: 
Line 27: from otopi import util
Line 28: from otopi import plugin


....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/__init__.py
Line 1: #
Line 2: # ovirt-engine-setup -- ovirt engine setup
s/setup/rename
Line 3: # Copyright (C) 2013 Red Hat, Inc.
Line 4: #
Line 5: # Licensed under the Apache License, Version 2.0 (the "License");
Line 6: # you may not use this file except in compliance with the License.


....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/misc.py
Line 1: #
Line 2: # ovirt-engine-setup -- ovirt engine setup
same
Line 3: # Copyright (C) 2013 Red Hat, Inc.
Line 4: #
Line 5: # Licensed under the Apache License, Version 2.0 (the "License");
Line 6: # you may not use this file except in compliance with the License.


....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/pki.py
Line 1: #
Line 2: # ovirt-engine-setup -- ovirt engine setup
same
Line 3: # Copyright (C) 2013 Red Hat, Inc.
Line 4: #
Line 5: # Licensed under the Apache License, Version 2.0 (the "License");
Line 6: # you may not use this file except in compliance with the License.


....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/postinstall.py
Line 1: #
Line 2: # ovirt-engine-setup -- ovirt engine setup
same
Line 3: # Copyright (C) 2013 Red Hat, Inc.
Line 4: #
Line 5: # Licensed under the Apache License, Version 2.0 (the "License");
Line 6: # you may not use this file except in compliance with the License.


Line 38: 
Line 39: 
Line 40: @util.export
Line 41: class Plugin(plugin.PluginBase):
Line 42:     """post install config file plugin."""
it's engine-setup now :)
Line 43: 
Line 44:     def __init__(self, context):
Line 45:         super(Plugin, self).__init__(context=context)
Line 46: 


....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/protocols.py
Line 1: #
Line 2: # ovirt-engine-setup -- ovirt engine setup
same
Line 3: # Copyright (C) 2013 Red Hat, Inc.
Line 4: #
Line 5: # Licensed under the Apache License, Version 2.0 (the "License");
Line 6: # you may not use this file except in compliance with the License.


....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/tools.py
Line 1: #
Line 2: # ovirt-engine-setup -- ovirt engine setup
same
Line 3: # Copyright (C) 2013 Red Hat, Inc.
Line 4: #
Line 5: # Licensed under the Apache License, Version 2.0 (the "License");
Line 6: # you may not use this file except in compliance with the License.


....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/uninstall.py
Line 1: #
Line 2: # ovirt-engine-setup -- ovirt engine setup
same
Line 3: # Copyright (C) 2013 Red Hat, Inc.
Line 4: #
Line 5: # Licensed under the Apache License, Version 2.0 (the "License");
Line 6: # you may not use this file except in compliance with the License.


-- 
To view, visit http://gerrit.ovirt.org/17408
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to