Alon Bar-Lev has posted comments on this change. Change subject: WIP: packaging: setup: host rename ......................................................................
Patch Set 11: (2 inline comments) .................................................... File packaging/setup/plugins/ovirt-engine-rename/core/engine.py Line 20: """Misc plugin.""" Line 21: Line 22: Line 23: import gettext Line 24: _ = lambda m: gettext.dgettext(message=m, domain='ovirt-engine-setup') yes. who ever translate the setup component will also translate the rename, it is the same domain. Line 25: Line 26: Line 27: from otopi import util Line 28: from otopi import plugin .................................................... File packaging/setup/plugins/ovirt-engine-rename/core/pki.py Line 1: # Line 2: # ovirt-engine-setup -- ovirt engine setup you can really really really really really really really really comment once per issue, I am sure didi will get it. Line 3: # Copyright (C) 2013 Red Hat, Inc. Line 4: # Line 5: # Licensed under the Apache License, Version 2.0 (the "License"); Line 6: # you may not use this file except in compliance with the License. -- To view, visit http://gerrit.ovirt.org/17408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
