Yair Zaslavsky has posted comments on this change.
Change subject: frontend: rewrite hode has upgrade logic
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 674:
Line 675: for (RpmVersion iso: isos) {
Line 676: // Major check
Line 677: if (Integer.parseInt(version_host[0].trim()) ==
iso.getMajor()) {
Line 678: // Minor and Build
Douglas, why not use the the Version class to do have these comparisons?
Have you tried? RpmVersion extends Version you will be able to perform
compareTo on a Version class composed from version_host[0], version_host [1],
version_host [2].
Line 679: if (iso.getMinor() >
Integer.parseInt(version_host[1].trim()) ||
Line 680: iso.getBuild() >
Integer.parseInt(version_host[2].trim())) {
Line 681: alert = true;
Line 682: break;
--
To view, visit http://gerrit.ovirt.org/17987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76bd2948524110ec80923e855bd1f49e09e17046
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
