Sahina Bose has posted comments on this change.

Change subject: engine: Added taskId to volume and brick
......................................................................


Patch Set 7:

(1 comment)

....................................................
File packaging/dbscripts/gluster_volumes_sp.sql
Line 348:                                                 v_vol_type 
VARCHAR(32),
Line 349:                                                 v_status VARCHAR(32),
Line 350:                                                 v_replica_count 
INTEGER,
Line 351:                                                 v_stripe_count 
INTEGER,
Line 352:                                                 v_task_id UUID)
I think it's better to have a separate procedure to updateTaskId
Line 353:     RETURNS VOID
Line 354:     AS $procedure$
Line 355: BEGIN
Line 356:     UPDATE gluster_volumes


-- 
To view, visit http://gerrit.ovirt.org/17992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82247bac8217a81f52b16092637885a336e455d5
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to