Yair Zaslavsky has posted comments on this change.
Change subject: engine: Added taskId to volume and brick
......................................................................
Patch Set 11:
(2 comments)
General question here,
I saw that your view performs 2 joins.
Do you think that in all your flows you really need the data from 3 tables, or
are there flows where you can fetch only partial data? at the virtualization
part of oVirt we did such improvements to views .
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java
Line 1: package org.ovirt.engine.core.common.businessentities.gluster;
Line 2:
Line 3: import javax.validation.constraints.NotNull;
Line 4:
Line 5: import org.ovirt.engine.core.common.asynctasks.gluster.GlusterAsyncTask;
Or just call it GlusterBrick? :)
Line 6: import org.ovirt.engine.core.common.businessentities.BusinessEntity;
Line 7: import org.ovirt.engine.core.common.businessentities.IVdcQueryable;
Line 8: import org.ovirt.engine.core.common.utils.ObjectUtils;
Line 9: import org.ovirt.engine.core.common.validation.group.CreateEntity;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
Line 168: public void setStripeCount(Integer stripeCount) {
Line 169: this.stripeCount = stripeCount;
Line 170: }
Line 171:
Line 172: public GlusterAsyncTask getTask() {
And while you're at it - I see two entities that have this method.
Maybe worth considering having an interface of GlusterAsyncTaskProvider (or
something like that) that the two business entities will derive from?
Or are we 100% sure we will not have future entities with methods of get/set
for GlusterAsyncTask?
Line 173: return asyncTask;
Line 174: }
Line 175:
Line 176: public void setTask(GlusterAsyncTask task) {
--
To view, visit http://gerrit.ovirt.org/17992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82247bac8217a81f52b16092637885a336e455d5
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
