Shubhendu Tripathi has posted comments on this change.
Change subject: engine: Added taskId to volume and brick
......................................................................
Patch Set 11: Code-Review+1
(2 comments)
2 minor comments
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java
Line 89: public void setStatus(GlusterStatus status) {
Line 90: this.status = status;
Line 91: }
Line 92:
Line 93: public GlusterAsyncTask getTask() {
You may think of renaming the methods as getAsyncTask() and setAsyncTask() or
rename the variable as "task" only
Line 94: return asyncTask;
Line 95: }
Line 96:
Line 97: public void setTask(GlusterAsyncTask asyncTask) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
Line 168: public void setStripeCount(Integer stripeCount) {
Line 169: this.stripeCount = stripeCount;
Line 170: }
Line 171:
Line 172: public GlusterAsyncTask getTask() {
You may think of renaming the methods as getAsyncTask() and setAsyncTask() or
rename the variable as "task" only
Line 173: return asyncTask;
Line 174: }
Line 175:
Line 176: public void setTask(GlusterAsyncTask task) {
--
To view, visit http://gerrit.ovirt.org/17992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82247bac8217a81f52b16092637885a336e455d5
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
