Laszlo Hornyak has posted comments on this change. Change subject: Code cleanup ......................................................................
Patch Set 1: (1 comment) I like it in general, one comment inline. I will test it. .................................................... File src/ovirtscheduler/oschedproxyd.py Line 36: logging.basicConfig(level=logging.DEBUG, Line 37: name="ovirt-scheduler-proxy", Line 38: format='%(asctime)s %(levelname)-8s %(message)s', Line 39: datefmt='%a, %d %b %Y %H:%M:%S', Line 40: filename=log_filename, Isn't it a problem that here we are still referencing the log_filename, which no longer exists in this scope? Line 41: filemode='w') Line 42: Line 43: Line 44: class ProxyServer(object): -- To view, visit http://gerrit.ovirt.org/18446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90e41fcfa46d7aee67de99c83b19937e24a359d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
