Martin Sivák has posted comments on this change. Change subject: Code cleanup ......................................................................
Patch Set 2: (3 comments) .................................................... Commit Message Line 4: Commit: Martin Sivak <[email protected]> Line 5: CommitDate: 2013-08-27 09:36:16 +0200 Line 6: Line 7: Code cleanup Line 8: I touched more than 200 lines for different reasons. And I do not think that putting Python is not Java to commit message is wise.. but I can probably elaborate a bit more. Line 9: Change-Id: I90e41fcfa46d7aee67de99c83b19937e24a359d3 .................................................... File src/ovirtscheduler/runner.py Line 44: except Exception as ex: Line 45: if not error: Line 46: self._error = "PythonMethodRunner::" \ Line 47: "Unable to parse result: %s" \ Line 48: " got error : %s " % ( Done Line 49: result, ex Line 50: ) Line 51: self._error = error Line 52: except Exception as ex: .................................................... File src/ovirtscheduler/utils.py Line 84: Line 85: return timedOut Line 86: Line 87: Line 88: def createFunctionStringArgs(args): I renamed it to createFunctionArgs and updated the docstring to explicitly state that this creates a structure that can be used in *args. Line 89: """ Line 90: converts args to a tuple we can pass to a function Line 91: """ Line 92: if args is None: -- To view, visit http://gerrit.ovirt.org/18446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90e41fcfa46d7aee67de99c83b19937e24a359d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
