Laszlo Hornyak has posted comments on this change. Change subject: Code cleanup ......................................................................
Patch Set 3: Verified-1 (1 comment) .................................................... File src/ovirtscheduler/request_handler.py Line 142: f, Line 143: utils.FILTER, Line 144: (hostIDs, vmID, properties_map)) Line 145: for f in avail_f Line 146: ) the problem here is that it generates an iterable structure rather than a list. When first iterating on teh list this is ok, but when iterating again (in aggregate_filter_results) it will have nothing left to iterate on, therefore it will return nothing Line 147: Line 148: for runner in filterRunners: Line 149: runner.start() Line 150: -- To view, visit http://gerrit.ovirt.org/18446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90e41fcfa46d7aee67de99c83b19937e24a359d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
