On Mon, 25 Jun 2018 14:48:54 +0900 Hermet Park <[email protected]> said:
> Hmm... do we really need to get a review for this kind of small fix? > At least, committers are proved, definitely know some patches are just > about trivial fix, not necessary get a review. if they wish to make work for themselves and others ... they are free to do so. review is not a requirement in efl or e etc. if you have commit access. > > On Mon, Jun 25, 2018 at 2:26 PM, Marcel Hollerbach < > [email protected]> wrote: > > > hermet pushed a commit to branch master. > > > > http://git.enlightenment.org/core/efl.git/commit/?id= > > c44c1e2ea077dc689f52239ff341b546e95f2480 > > > > commit c44c1e2ea077dc689f52239ff341b546e95f2480 > > Author: Marcel Hollerbach <[email protected]> > > Date: Mon Jun 25 14:25:52 2018 +0900 > > > > efl_gfx_path: make counters unsigned > > > > Summary: > > we are comparing to unsigned number, and the number are moving strongly > > from 0 up. > > Depends on D6380 > > > > Reviewers: devilhorns > > > > Subscribers: Hermet, cedric, #committers, zmike > > > > Tags: #efl > > > > Differential Revision: https://phab.enlightenment.org/D6381 > > --- > > src/lib/efl/interfaces/efl_gfx_path.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/lib/efl/interfaces/efl_gfx_path.c > > b/src/lib/efl/interfaces/efl_gfx_path.c > > index ca3a842b99..97439c0fee 100644 > > --- a/src/lib/efl/interfaces/efl_gfx_path.c > > +++ b/src/lib/efl/interfaces/efl_gfx_path.c > > @@ -335,7 +335,7 @@ _efl_gfx_path_interpolate(Eo *obj, Efl_Gfx_Path_Data > > *pd, > > { > > double *to_pts = to_pd->points; > > double *from_pts = from_pd->points; > > - int i, j; > > + unsigned int i, j; > > > > for (i = 0; cmds[i] != EFL_GFX_PATH_COMMAND_TYPE_END; > > i++) > > for (j = 0; j < _efl_gfx_path_command_length(cmds[i]); > > j++) > > > > -- > > > > > > > > > -- > Regards, Hermet > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- Carsten Haitzler - [email protected] ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
