On 2018-06-29 09:29, Carsten Haitzler wrote:
On Fri, 29 Jun 2018 05:44:37 +0000 jaquil...@eagleeyet.net said:
I will start working on this once I am back from my honeymoon on the
22nd as I am getting married tomorrow so hopefully I can find some
tags
on phab by then to work on with some guidance :)
oh congrats + good luck! don't let anything distract you from your more
important tasks tomorrow. :)
Hey Raster,
Just saw this now it was a killer night. Off the grid for the next two
weeks as of tomorrow. Hope to get things going to help with creating
unit tests when I am back.
On 2018-06-29 05:40, Carsten Haitzler wrote:
> On Fri, 29 Jun 2018 05:31:20 +0000 jaquil...@eagleeyet.net said:
>
>> Can someone start tagging bugs that need unit tests or is that already
>> done?
>
> That is a good idea. From now on when I see a bug that seems it could
> do with a
> unit test (i.e. it's readily unit-testable), I'll add some tag - TBD.
>
>> On 2018-06-28 11:28, Carsten Haitzler wrote:
>> > On Thu, 28 Jun 2018 05:25:42 +0000 jaquil...@eagleeyet.net said:
>> >
>> >> Hi all,
>> >>
>> >> I think writing unit tests would be good for someone like me whose new
>> >> to the code base if it helps to catch issues. My question though is do
>> >> we have a tags on phab where senior devs post tickets for tests that
>> >> someone like me can grab and start working on?
>> >
>> > you are absolutely right. it would be very helpful. turning a bug into
>> > a unit
>> > test would be a great way of tackling little bite-sized bits of work
>> > that still
>> > are kind of a time-sink.
>> >
>> >> On 2018-06-28 04:36, Carsten Haitzler wrote:
>> >> > On Wed, 27 Jun 2018 13:14:39 -0400 Mike Blumenkrantz
>> >> > <michael.blumenkra...@gmail.com> said:
>> >> >
>> >> >> I don't think we need to do testing in EFL, we do have unit test
>> >> >> coverage
>> >> >> for these functions and they pass. Given that this has never occurred
>> >> >> in
>> >> >> any other circumstance (and we have testing), this should be
>> >> >> considered an
>> >> >> application bug only; I've already filed a ticket for it.
>> >> >
>> >> > Well first reproducing it (in a test environment) and grabbing a
>> >> > backtrace to
>> >> > unlink() functions called with gdb so we know the code path that
>> >> > caused it. I
>> >> > to am doubtful it's EFL itself just deciding to delete. It's probably
>> >> > something
>> >> > triggered by the app, but could it be a change in response from EFL
>> >> > that then
>> >> > triggers code logic to do this? We won't know until we find the root
>> >> > trigger
>> >> > (the above bt) and then figure out the logic that caused it to run. :)
>> >> >
>> >> >> On Wed, Jun 27, 2018 at 11:03 AM Stephen Houston
>> >> >> <smhousto...@gmail.com>
>> >> >> wrote:
>> >> >>
>> >> >> > Okay we need to do some testing and make sure changes to
>> >> >> > eina/ecore/eio file ops are not the culprit, because if they are...
>> >> >> > Ephoto, Rage, Terminology, EFM, many gadgets, etc... are all
>> >> >> > possible to do the same.
>> >> >> >
>> >> >> > On Wed, Jun 27, 2018, 9:56 AM Xavi Artigas
>> >> >> > <xavierarti...@gmail.com> wrote:
>> >> >> >
>> >> >> > > What? I have been working with it on my dev machine!
>> >> >> > > I hope my recent changes to bring it back to life didn't cause
>> >> >> > > this...
>> >> >> > >
>> >> >> > > Xavi
>> >> >> > >
>> >> >> > > El lun., 25 jun. 2018 9:06 p. m., Mike Blumenkrantz <
>> >> >> > > michael.blumenkra...@gmail.com> escribió:
>> >> >> > >
>> >> >> > > > Hi,
>> >> >> > > >
>> >> >> > > > Do not attempt to use Eflete.
>> >> >> > > >
>> >> >> > > > I was attempting to examine a related issue from phab today on
>> >> >> > > > my test machine and Eflete somehow managed to delete nearly
>> >> >> > > > EVERYTHING from my
>> >> >> > > home
>> >> >> > > > directory. All my .directories, all my source trees, everything
>> >> >> > deleted.
>> >> >> > > >
>> >> >> > > > Fortunately, this was only a testing machine and nothing other
>> >> >> > > > than
>> >> >> > some
>> >> >> > > > local configs were lost.
>> >> >> > > >
>> >> >> > > > DO NOT USE EFLETE.
>> >> >> > > >
>> >> >> > > >
>> >> >> > > > Regards,
>> >> >> > > > Mike
>> >> >> > > >
>> >> >> > > >
>> >> >> > >
>> >> >> >
------------------------------------------------------------------------------
>> >> >> > > > Check out the vibrant tech community on one of the world's most
>> >> >> > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> >> >> > > > _______________________________________________
>> >> >> > > > enlightenment-devel mailing list
>> >> >> > > > enlightenment-devel@lists.sourceforge.net
>> >> >> > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >> >> > > >
>> >> >> > >
>> >> >> > >
>> >> >> >
------------------------------------------------------------------------------
>> >> >> > > Check out the vibrant tech community on one of the world's most
>> >> >> > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> >> >> > > _______________________________________________
>> >> >> > > enlightenment-devel mailing list
>> >> >> > > enlightenment-devel@lists.sourceforge.net
>> >> >> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >> >> > >
>> >> >> >
>> >> >> >
------------------------------------------------------------------------------
>> >> >> > Check out the vibrant tech community on one of the world's most
>> >> >> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> >> >> > _______________________________________________
>> >> >> > enlightenment-devel mailing list
>> >> >> > enlightenment-devel@lists.sourceforge.net
>> >> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >> >> >
>> >> >>
------------------------------------------------------------------------------
>> >> >> Check out the vibrant tech community on one of the world's most
>> >> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> >> >> _______________________________________________
>> >> >> enlightenment-devel mailing list
>> >> >> enlightenment-devel@lists.sourceforge.net
>> >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >>
>> >>
------------------------------------------------------------------------------
>> >> Check out the vibrant tech community on one of the world's most
>> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> >> _______________________________________________
>> >> enlightenment-devel mailing list
>> >> enlightenment-devel@lists.sourceforge.net
>> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
