On Thu, Aug 12, 2010 at 2:47 PM, Kim Woelders <[email protected]> wrote: > I think we are in the personal taste department here, so it's probably > dangerous just to change this all over.
I took embryo as the first victim because it has examples of most of the cases. I would really like to apply the changes universally, but once people start complaining on his project, I stop. Not forcing anything in anyone here... I just like the idea of having a uniform style along the entire repository. And then, once people know what the style is, it'll be preserved :-D > > As for e16 I think I changed my mind somewhere along the way in favor of > what you suggest, so e16 is a bit messy here :) > Feel free to make these changes in the E16 subtree. Good!! I think most of them are in E16 dir :-D > > One question though - there are a lot of constructions like > > if ((p = strchr(s, ' ')) == NULL) > return 0; > > I assume this would be changed to > > if (!(p = strchr(s, ' '))) > return 0; As of now, yes. > > which I don't like much. I'd prefer > > p = strchr(s, ' '); > if (!p) > return 0; > > Would it be possible to teach coccinelle that? :) Yes, except that for 'while', 'for' and maybe other cases it will not work. If we do that, we'll introduce a bug. Then, what do I do? Keep them different for "if / while / for / '?' / other_conditions", introduce a bug or just apply as is? Lucas De Marchi ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
