On Wednesday, 11 August 2010, at 13:35:26 (-0700), Enlightenment SVN wrote:
> Log: > Remove comparisons to NULL > > Rather than using "== NULL" or "!= NULL", use expression or !expression > where > possible. > > Patch automatically generated by coccinelle from badnull.cocci and > badnull2.cocci I think it's great that such a tool exists, and what it can do is impressive. But in this particular case, you seem to be "correcting" what is really a stylistic choice, not a programming error, and there are very valid arguments for having explicit comparisons to NULL (or 0, for that matter), not the least of which being explicit readability. I'm all for consistency, and this is certainly a great tool for producing that consistency, but shouldn't a concensus be reached amongst the developers for stylistic personal preference changes as opposed to actual algorithmic correctness? Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <m...@kainx.org> Linux Server/Cluster Admin, LBL.gov Author, Eterm (www.eterm.org) ----------------------------------------------------------------------- "Don't go making all these promises you know you cannot keep. There's a time to play a king and a time to be the thief. 'Cause if you're making all these promises you know you cannot keep, you know time will be the thief, and your fallen king will end up alone." -- Savage Garden, "Promises" ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
