On Mon, 23 Aug 2010 20:46:39 +0200 Albin Tonnerre <albin.tonne...@gmail.com> wrote:
> On Mon, 23 Aug 2010 15:28 -0300, Lucas De Marchi wrote : > > On Mon, Aug 23, 2010 at 2:55 PM, Enlightenment SVN > > <no-re...@enlightenment.org> wrote: > > > Log: > > > Revert coccinelle changes. > > > > > > Using !! instead of != NULL results in significantly and > > > unacceptably less readable code, and I refuse to accept those > > > changes. Unfortunately, since they were all done at once, I have > > > to revert the whole thing. Oh well. :( > > > > Did you revert the whole thing? Why do you have to do so? > > > > At least for EFL, it should be like this as agreed on mailing > > list / irc > > The particular change Michael is unhappy with is != NULL => !!, and > he did express his disagreement about it (and so did I, FWIW). That > being said, I'm not going to fight over it if the general opinion is > that it's fine. I'm going to agree that !! is unreadable. Um, does that mean negate the negation, hence do nothing, or is their an obscure !! operator I have somehow missed in my decades of C programming? Don't think I have ever seen it before, so would not count is as "well known C practice". No doubt for the same reason that double negatives are discouraged in English. Not being equal to NULL says something, negating the negation is just noise. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world.
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
