On Thu,  7 Oct 2010 17:59:04 -0300
Raphael Kubo da Costa <k...@profusion.mobi> wrote:

> ---
>  src/lib/ecore_con/ecore_con_url.c |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lib/ecore_con/ecore_con_url.c
> b/src/lib/ecore_con/ecore_con_url.c index 664efc3..01937d9 100644
> --- a/src/lib/ecore_con/ecore_con_url.c
> +++ b/src/lib/ecore_con/ecore_con_url.c
> @@ -965,8 +965,14 @@ ecore_con_url_http_post_send(Ecore_Con_Url
> *url_con, void *httppost) }
>  
>  /**
> - * Enable or disable libcurl verbose output, useful for debug
> - * @return  FIXME: To be more documented.
> + * Toggle libcurl's verbose output.
> + *
> + * If @p verbose is @c EINA_TRUE, libcurl will output a lot of
> verbose
> + * information about its operations, which is useful for
> + * debugging. The verbose information will be sent to stderr.
> + *
> + * @param url_con Ecore_Con_Url instance which will be acted upon.
> + * @param verbose Whether or not to enable libcurl's verbose output.
>   */
>  EAPI void
>  ecore_con_url_verbose_set(Ecore_Con_Url *url_con, Eina_Bool verbose)
Looks good, but make sure to check the return code from curl.  All curl
functions that have a return code should be Eina_Bool (returning true
if successful) and log any errors with ERR.  It's okay if you have to
change current api to do this because the functions can still be used
the same way, though it will then be possible to check for failure.

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to