Hi, Kubo
On Thu, Oct 7, 2010 at 5:59 PM, Raphael Kubo da Costa
<[email protected]> wrote:
> In practice, it was already being treated as an Eina_Bool, so let us
> declare it as such and simplify the code.
> ---
> src/lib/ecore_con/Ecore_Con.h | 2 +-
> src/lib/ecore_con/ecore_con_url.c | 10 ++--------
> 2 files changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/src/lib/ecore_con/Ecore_Con.h b/src/lib/ecore_con/Ecore_Con.h
> index fa333f8..e98ae0f 100644
> --- a/src/lib/ecore_con/Ecore_Con.h
> +++ b/src/lib/ecore_con/Ecore_Con.h
> @@ -493,7 +493,7 @@ EAPI Eina_Bool
> ecore_con_url_ftp_upload(Ecore_Con_Url *url_con,
> const char *pass,
> const char *upload_dir);
> EAPI void ecore_con_url_verbose_set(Ecore_Con_Url *url_con,
> - int verbose);
> + Eina_Bool verbose);
This is EAPI! I little bit late to change this I think.
> EAPI void
> -ecore_con_url_verbose_set(Ecore_Con_Url *url_con, int verbose)
> +ecore_con_url_verbose_set(Ecore_Con_Url *url_con, Eina_Bool verbose)
> {
> #ifdef HAVE_CURL
> if (!ECORE_MAGIC_CHECK(url_con, ECORE_MAGIC_CON_URL))
> @@ -985,13 +985,7 @@ ecore_con_url_verbose_set(Ecore_Con_Url *url_con, int
> verbose)
> if (!url_con->url)
> return;
>
> - if (verbose ==
> - EINA_TRUE)
> - curl_easy_setopt(url_con->curl_easy, CURLOPT_VERBOSE,
> - 1);
> - else
> - curl_easy_setopt(url_con->curl_easy, CURLOPT_VERBOSE, 0);
> -
> + curl_easy_setopt(url_con->curl_easy, CURLOPT_VERBOSE, (int)verbose);
Humn... although changing the method signature is not good now, the
implementation as of now is buggy. It's receiving int and testing ==
EINA_TRUE. So, if user gives, let's say, 2 as parameter it will treat
it as false :-(. Bad discomfitor, bad...
Lucas De Marchi
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
