At Thu, 7 Oct 2010 19:09:48 -0400, Michael Blumenkrantz wrote: > Looks good, but make sure to check the return code from curl. All curl > functions that have a return code should be Eina_Bool (returning true > if successful) and log any errors with ERR.
I originally thought of doing that, however the rest of the code does not check for libcurl's return codes. I can try to work on a separate patch to address all these issues at once if that's preferrable. > It's okay if you have to > change current api to do this because the functions can still be used > the same way, though it will then be possible to check for failure. How OK is that with regards to API stability? Most of the current ecore_con_url functions would have their return values changed. -- Raphael Kubo da Costa ProFUSION embedded systems http://profusion.mobi ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
