On Wed, 12 Jan 2011 15:43:07 +0900 ChunEon Park <[email protected]> said:
cool! much better! in svn it is! > Hello, > > Thanks for your advice. > > I modified then send patches again. > > Please review then apply them. > > 001 - elm_transit_paused_set / elm_transit_paused_get / > elm_transit_progress_value_get > 002 - modified some test sample codes for looking better. > > Thanks! > > Best Regards. > hermet > > -----Original Message----- > From: Carsten Haitzler (The Rasterman) [mailto:[email protected]] > Sent: Tuesday, January 11, 2011 3:05 PM > To: ChunEon Park > Cc: [email protected] > Subject: Re: [E-devel] [PATCH] elm_transit > > On Mon, 10 Jan 2011 21:39:32 +0900 ChunEon Park <[email protected]> > said: > > oh dear. bad me - i didnt notice the isse. you declared elm_transit_add as: > > elm_transit_add() - not elm_transit_add(void). that means the compiler > doesnt > find errors when passing parameters. a function declared with > elm_transit_add() > in C means "this accepts 0 or MORE parameters - which are undefined". > basically > it means it wont complain if you call it with no params, 1, 2, or N - it > doesnt > care. thats really bad. thus the bug lipped through and your fix. first that > goes into svn. > > you have some problems though with pause & resume. on run you never reset > delayed to 0. :) so if you want to run multiple times and have paused it at > a > time in the past with an older run... it'll get things wrong. also you have > pause() and resume - why not have a pause_set(transit, EINA_TRUE/FALSE); and > a > pause_get() so you can set and get the paused state. that'd be better. also > i > see another if formatting thing: > > + if(transit->animator) > > no space after if :) could you fix the above? :) > > > Dear All. > > > > Here is elm_transit patches. > > > > 001_elm_transit.txt > > Added elm_transit_pause, elm_transit_resume, > elm_transit_progress_value_get > > > > 002_elm_transit.txt > > fixed customized transit sample error. > > > > > > Check it then apply it please. > > > > Thanks. > > > > Best Regards > > Hermet > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
