Thanks it looks ok to me. Working good. But sometimes I got -1 or -2 page for the result. I think it's a scroller bug not yours.
I got more comments now. They are trivial, so please apply this to your codes. 1. Add const to Evas_Object of getter APIs. elm_gengrid_current_page_get(const Evas_Object *... elm_gengrid_last_page_get(const Evas_Object *... I'll fix elm_scroller_currnet_page_get, elm_scroller_last_page_get. They're wrong. 2. Indentation Do not use tab for efl code. Use spaces. You may need to refer coding convention for e. http://trac.enlightenment.org/e/wiki/ECoding 3. Trailing white spaces Do not introduce trailing whitespaces. I see a white space at the end of below code and so on. Please check all codes. fprintf(stdout, "Grid current horiz page is %d, vert page is %d\n", if (pagenumber_h) 4. Spacing Put spaces before and after =. int h_pagenumber=0, v_pagenumber=0; I think the overall coding convention is wrong. Please check the link again. http://trac.enlightenment.org/e/wiki/ECoding Otherwise, this is cool! Thanks. Daniel Juyung Seo (SeoZ) On Fri, Sep 2, 2011 at 10:34 AM, Benjamin Drucker <[email protected]> wrote: >>Hello, >>This looks ok to me. >> >>1. Can you attach the diff file to this mail instead of pasting diff >>into the email contents? >>2. Can you add any sample code either elementary test or src/examples? >> >>Thanks. >>Daniel Juyung Seo (SeoZ) > > Patch is attached, with > a) example usage as part of elemental/src/examples/gengrid_example_01.c; and > b) a bug fix to related code in elementary/src/lib/els_scroller.c > (there was a div/0 case) > > ------------------------------------------------------------------------------ > Special Offer -- Download ArcSight Logger for FREE! > Finally, a world-class log management solution at an even better > price-free! And you'll get a free "Love Thy Logs" t-shirt when you > download Logger. Secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsisghtdev2dev > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
