Dear Benjamin Drucker, Thanks for the patch. But you just applied one of my 4 comments. Can you apply others as well?
And when you send patches code to enlightenment mailing list, it's recommended to separate patches for each feature. ex) gengrid page patch, gengrid longpress signal patch, ... It helps reviewer to review quickly, because all devs are busy. I hope this review will not discourage you but this will help you involve in e project more. Thank you. Daniel Juyung Seo (SeoZ) On Thu, Sep 8, 2011 at 6:38 PM, Benjamin Drucker <[email protected]> wrote: > I am submitting a new version of this patch that conforms to the > whitespace rules for e17, as per a suggestion from Daniel. > > PS: In this patch is also a small cosmetic change which publishes an > extant gengrid "longpress" event that never got documented. > > On Thu, Sep 1, 2011 at 6:34 PM, Benjamin Drucker > <[email protected]> wrote: >>>Hello, >>>This looks ok to me. >>> >>>1. Can you attach the diff file to this mail instead of pasting diff >>>into the email contents? >>>2. Can you add any sample code either elementary test or src/examples? >>> >>>Thanks. >>>Daniel Juyung Seo (SeoZ) >> >> Patch is attached, with >> a) example usage as part of elemental/src/examples/gengrid_example_01.c; and >> b) a bug fix to related code in elementary/src/lib/els_scroller.c >> (there was a div/0 case) >> > > ------------------------------------------------------------------------------ > Doing More with Less: The Next Generation Virtual Desktop > What are the key obstacles that have prevented many mid-market businesses > from deploying virtual desktops? How do next-generation virtual desktops > provide companies an easier-to-deploy, easier-to-manage and more affordable > virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ Why Cloud-Based Security and Archiving Make Sense Osterman Research conducted this study that outlines how and why cloud computing security and archiving is rapidly being adopted across the IT space for its ease of implementation, lower cost, and increased reliability. Learn more. http://www.accelacomm.com/jaw/sfnl/114/51425301/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
