On Thu, 8 Sep 2011 02:38:56 -0700 Benjamin Drucker <[email protected]> said:
overall decent patch. only issues are: 1. i still see tabs. (i see only 1 instance in th fprintf debug in +_grid_scroll_stopped_cb() 2. still no const for Evas_Object * in the _get api's if you send it again as an updated patch with the above changes we can apply. :) > I am submitting a new version of this patch that conforms to the > whitespace rules for e17, as per a suggestion from Daniel. > > PS: In this patch is also a small cosmetic change which publishes an > extant gengrid "longpress" event that never got documented. > > On Thu, Sep 1, 2011 at 6:34 PM, Benjamin Drucker > <[email protected]> wrote: > >>Hello, > >>This looks ok to me. > >> > >>1. Can you attach the diff file to this mail instead of pasting diff > >>into the email contents? > >>2. Can you add any sample code either elementary test or src/examples? > >> > >>Thanks. > >>Daniel Juyung Seo (SeoZ) > > > > Patch is attached, with > > a) example usage as part of elemental/src/examples/gengrid_example_01.c; and > > b) a bug fix to related code in elementary/src/lib/els_scroller.c > > (there was a div/0 case) > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
