On Mon, Sep 5, 2011 at 4:59 PM, Youness Alaoui <[email protected]> wrote: > On Mon, Sep 5, 2011 at 1:42 PM, Gustavo Sverzut Barbieri < > [email protected]> wrote: >> On Mon, Sep 5, 2011 at 6:48 AM, Youness Alaoui >> <[email protected]> wrote: >> > Hi all, >> > >> > As most people in #e.fr know, for the past week, I've been porting the >> EFL >> > to the PS3, and during my work I've stumbled across a few bugs/issues >> with >> > the existing code that needed fixing (and which was unrelated to the PS3 >> > port). >> > I've made a git clone of the svn and I've pushed my changes to my git >> > remote. >> > Cedric asked me to send an email with the patches, I would prefer for the >> > patches to be reviewed on github since you can comment on individual >> lines >> > and commits making the review process much easier. >> > If you insist I can make them into patch files and send them over by >> mail, >> > but I'd rather not. >> > You can view my commits here : >> > https://github.com/kakaroto/e17/commits/to-review >> > After they are reviewed and if everyone is ok with the quality, i'd like >> to >> > request svn access so I can push the commits myself onto the svn server >> (I >> > wouldn't like seeing my patches committed under someone else's name to be >> > honest). Boris (billiob) can vouch for me, and I do understand the >> > responsabilities of having commit access (I've been project manager of >> aMSN >> > for about 10 years now), and I promise I wouldn't mess with anything. My >> > code is usually good quality and well tested before it gets pushed, and >> > also, of course, until I get used to the E team's coding style and >> > standards, I wouldn't commit anything that wouldn't have been previously >> > reviewed and authorized by one of the long-term E developers. >> > So please consider my request, if you'd like to see more patches from me >> > before giving me svn access, then I suppose it can wait since none of the >> > patches I sent are critical, but I'm ready to accept it if you'd like to >> > push the commits now under someone else's authorship. >> > I have a few other patches that I'd like to revisit and clean before >> asking >> > for a review, then there will be the ps3 specific changes. >> > >> > As for those curious about the PS3 port, it went really well, I've made a >> > new library to compensate for the missing APIs from the ps3 SDK (just >> like >> > Evil is for windows), and I've named it Escape (in reference to >> jailbreaking >> > the ps3). I was able to port eina, eet, evas, ecore, embryo, edje and >> > elementary. >> > Expedite runs fine, but the performance isn't so great for some of the >> > blending tests, and I was also able to run the eskiss game, although the >> > extremely horrible fps makes it impossible to play. Although I finished >> > porting Elementary, I haven't yet taken the time to actually test it on >> the >> > PS3, so the port status for that library is still unknown for the moment >> as >> > I'm concentrating on improving performance. >> > I have now started to write our own PS3 specific evas engine that uses >> > PSL1GHT (the unofficial SDK) and it's working fine so far, although >> > everything is in software for now, so in terms of performance, there is >> only >> > a very small improvement over the SDL engine. I have also implemented the >> > mouse and keyboard support in Expedite (about to copy that over into an >> > ecore-psl1ght then integrate into ecore-evas). We have started playing >> with >> > blitting and blending using the hardware acceleration, but we're having >> some >> > issues with the API and the NV pipeline (I'm a total graphics n00b), but >> I >> > expect it to be fixed soon enough, then the performance should be >> improved >> > greatly. >> > >> > For the future there is still more work to be done, I'd like to start >> > documenting (at least to a minimum) the internals of the E libs because >> > figuring out the internal API for creating an engine and all that >> > image_cache_engine stuff has been a nightmare. But mostly, I'm going to >> need >> > to define a new API for joystick support as it will be needed by any >> > would-be ps3 developer who would like to use the controllers in their >> games. >> >> Dude, there is no weirdo policies over here. If you want to >> contribute, just give me your ssh key and info.txt that I add you. You >> already did some contributions and discussed a lot with us in IRC over >> the years. And as raster says "if you screw svn, we can just revert >> and remove your access" :-) >> >> Given the loooong time I know you, have no problems in adding you to >> svn straight away. Also thanks for your PS3 hack stuff, really amazed >> to have such great hackers to join our project. >> > > Great, thanks a lot for your trust! > How about the code review? This email was mainly about the patches, not > about svn access, and all 3 replies it received were about the svn access > and/or authorship :p
Yes, but as I said at IRC our workflow is a bit crazy and until we fix it, you better just do it :-) 0 - Likely people will not take time to review external changes, too few resources, too busy, then.. 1 - Commit to SVN parts that do not touch core infrastructure (ie: modules, new libs, etc) 2 - Give it a little (1-2 days) pause and commit other stuff that touches the core but are not radical changes 3 - Mail patches about radical changes... they shouldn't be much anyways (for what you're doing) -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
