Re: [E-devel] [PATCH] Fix the bug that user cannot input key

[Jihoon Kim]

At this moment, space is processed in case of WM_KEYDOWN and WM_CHAR.

Therefore, 'space' key is processed twice, it makes bug.

In previous my patch, I changed keyname and string wrong.

I send the revised patch again.

Would you please review again?

-----Original Message-----
From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] 
Sent: Monday, October 31, 2011 12:28 PM
To: Enlightenment developer list
Cc: Jihoon Kim
Subject: Re: [E-devel] [PATCH] Fix the bug that user cannot input key

On Fri, 28 Oct 2011 21:03:49 +0900 Jihoon Kim <jihoon48....@samsung.com>
said:

i don't think this is right. this means u get 2 key press events, with with
key string, one without... :(

> Hi, EFL developers and Vincent.
> 
> On Windows 7, there are some bugs related to key input in elementary_test.
> 1. alphabet and symbol characters doesn't be inputted in elementary entry.
> 2. When the space key is pressed, "space" string is entered in elementary
> entry.
> 
> In this patch, I've tried to fix the above bugs.
> It works well when I tested.
> 
> Would you please review this patch?
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


Index: src/lib/ecore_win32/ecore_win32.c
===================================================================
--- src/lib/ecore_win32/ecore_win32.c   (revision 64494)
+++ src/lib/ecore_win32/ecore_win32.c   (working copy)
@@ -86,10 +86,10 @@ _ecore_win32_window_procedure(HWND   window,
        INF("keydown message");
        _ecore_win32_event_handle_key_press(data, 1);
        return 0;
-     /* case WM_CHAR: */
-     /*   INF("char message"); */
-     /*   _ecore_win32_event_handle_key_press(data, 0); */
-     /*   return 0; */
+     case WM_CHAR:
+       INF("char message");
+       _ecore_win32_event_handle_key_press(data, 0);
+       return 0;
      case WM_KEYUP:
        INF("keyup message");
        _ecore_win32_event_handle_key_release(data, 1);
Index: src/lib/ecore_win32/ecore_win32_event.c
===================================================================
--- src/lib/ecore_win32/ecore_win32_event.c     (revision 64494)
+++ src/lib/ecore_win32/ecore_win32_event.c     (working copy)
@@ -798,11 +798,6 @@ _ecore_win32_event_keystroke_get(int    key,
            kc = "KP_Delete";
          }
        break;
-     case VK_SPACE:
-       kn = "space";
-       ks = "space";
-       kc = "space";
-       break;
      case VK_F1:
        kn = "F1";
        ks = "F1";
@@ -994,7 +989,7 @@ _ecore_win32_event_char_get(int    key,
      case VK_SPACE:
        strncpy(kn, "space", 32);
        strncpy(ks, "space", 32);
-       strncpy(kc, "space", 32);
+       strncpy(kc, " ", 32);
        break;
      default:
        /* displayable characters */


------------------------------------------------------------------------------
Get your Android app more play: Bring it to the BlackBerry PlayBook 
in minutes. BlackBerry App World&#153; now supports Android&#153; Apps 
for the BlackBerry&reg; PlayBook&#153;. Discover just how easy and simple 
it is! http://p.sf.net/sfu/android-dev2dev

_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel