On Fri, 11 Nov 2011 21:00:23 -0500 Christopher Michael <cpmicha...@comcast.net>
said:

> On 11/11/11 20:42, Carsten Haitzler (The Rasterman) wrote:
> > On Fri, 11 Nov 2011 20:08:09 -0500 Christopher
> > Michael<cpmicha...@comcast.net> said:
> >
> >> On 11/11/11 19:54, Enlightenment SVN wrote:
> >>> Log:
> >>> back to unsigned long. code was actually correct as-is.
> >>>
> >> If that's actually correct, then the 'fix' for the xcb version should be
> >> reverted also ;)
> >
> > yeah  found it. fixed. :) thanks for reminding
> >
> No worries. Thanks for the fix ;)
> 
> > fyi - notice that even with those changes.. a whole bunch of other funcs in
> > the same file were still using unsigned long * so the code was
> > inconsistently changed too... which is bad :)
> >
> Indeed. Was a patch from *bsd people (see commit from vtorri wrt bsd 
> patch). No worries tho, it's straightened out now ;)

oh sure - originally. i'm just pointing out that it was that way for a
reason :) much more code followed the same pattern. if you change 1 instance
of a pattern... you need to be sure you really do NEED to change it. you
didn't do it - just pointing it out to those watching :)

-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to