On Sat, 12 Nov 2011, Carsten Haitzler (The Rasterman) wrote:
> On Fri, 11 Nov 2011 20:08:09 -0500 Christopher Michael > <cpmicha...@comcast.net> > said: > >> On 11/11/11 19:54, Enlightenment SVN wrote: >>> Log: >>> back to unsigned long. code was actually correct as-is. >>> >> If that's actually correct, then the 'fix' for the xcb version should be >> reverted also ;) > > yeah found it. fixed. :) thanks for reminding > > fyi - notice that even with those changes.. a whole bunch of other funcs in > the > same file were still using unsigned long * so the code was inconsistently > changed too... which is bad :) forget my previous mail I do not agree. I don't see anywhere in the protocol specification where a long is used: http://cgit.freedesktop.org/xorg/proto/xproto/tree/specs/encoding.xml http://cgit.freedesktop.org/xorg/proto/xproto/tree/specs/sect1-9.xml Vincent > >> dh >> >>> >>> >>> Author: raster >>> Date: 2011-11-11 16:54:22 -0800 (Fri, 11 Nov 2011) >>> New Revision: 65082 >>> Trac: http://trac.enlightenment.org/e/changeset/65082 >>> >>> Modified: >>> trunk/ecore/src/lib/ecore_x/xlib/ecore_x_window_prop.c >>> >>> Modified: trunk/ecore/src/lib/ecore_x/xlib/ecore_x_window_prop.c >>> =================================================================== >>> --- trunk/ecore/src/lib/ecore_x/xlib/ecore_x_window_prop.c >>> 2011-11-11 21:59:02 UTC (rev 65081) +++ >>> trunk/ecore/src/lib/ecore_x/xlib/ecore_x_window_prop.c 2011-11-12 >>> 00:54:22 UTC (rev 65082) @@ -131,7 +131,7 @@ return -1; >>> } >>> for (i = 0; i< num_ret; i++) >>> - val[i] = ((unsigned int *)prop_ret)[i]; >>> + val[i] = ((unsigned long *)prop_ret)[i]; >>> num = num_ret; >>> *plst = val; >>> } >>> >> >> >> ------------------------------------------------------------------------------ >> RSA(R) Conference 2012 >> Save $700 by Nov 18 >> Register now >> http://p.sf.net/sfu/rsa-sfdev2dev1 >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > ------------------------------------------------------------------------------ > RSA(R) Conference 2012 > Save $700 by Nov 18 > Register now > http://p.sf.net/sfu/rsa-sfdev2dev1 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
