On Fri, Dec 02, 2011 at 03:37:30PM +0900, Carsten Haitzler wrote: > On Thu, 1 Dec 2011 17:41:17 +0100 Joerg Sonnenberger <jo...@britannica.bec.de> > said: > > this is really late... and a lot of these patches i find questionable. i'll > question here (things not questioned seem ok): > > 1. __SUNPRO_C instead of __sun <- explain why you dont just ADD an extra || > defined(__SUNPRO_C) and why the check for __sun should be removed?
I think you are reading the diff wrong. It replaces __SUNPRO_C (the compiler specific macro) with __sun (the platform specific macro). I don't mind using it as additional case though. > 2. all the chasting and changing to unsigned char for passing into isspace() - > isspace() actually takes an int, not unsigned char, so this just doesn't make > sense. :( (well it does according to the manual page i have) Please read the manual again. ctype.h stuff takes an integer argument, but the value must be -1..255 (for 8bit char and EOF==-1). It is undefined behavior to pass anything else. Especially in programs using setlocale(), the result for 0xff as input byte can make a real difference for platforms with signed char. Joerg ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
