2011/12/15 Tom Hacohen <tom.haco...@partner.samsung.com>:
> I have a couple of more suggestions:
> 1. I'm very very sorry, I just saw something I missed in Daniel's comment,
> get/set APIs is actually not needed, sorry. :((( please remove.
> The reason for that is that those are configurations you set on the
> environment and should be of no concern to the programmer. I'm very sorry,
> but these should be removed. You can leave them there if you want, and I
> will gladly remove the to pay for my mistake.
> 2. No need for wd->zoom_finger_enable, just use the elm config values, the
> only reasons the other values are there is that we thought people may want
> to change them manually (but as said in #1, we don't want that atm). This is
> a patent issue, it should not be manually overridden per object, really no
> use for that.
> 3. There are still unrelated format changes (for example in
> Elementary.h.in).
> 4. The error message should explain more about why it's disabled and what to
> do to enable it (config).
>
> Again, I'm very sorry. :(
No problem!! I have learned a lot. :D
I removed whole gesture layer's get/set APIs.
2011/12/16 Tom Hacohen <tom.haco...@partner.samsung.com>:
> In my point of view, it sounds unrelated to what gesture layer does in my
> pov, but I only read the engadget summary, and not the whole document. And
> even if I have read the whole thing, I'm not sure I have the legal
> qualifications to determine anything. :)
Yeah, Apple does not have complete pinch to zoom patent.
But, I don't know who have this or It may be patent pending :-( ...
--
BRs,
Kim.
Index: src/lib/elm_config.c
===================================================================
--- src/lib/elm_config.c (리ë¹ì 66265)
+++ src/lib/elm_config.c (ìì
ì¬ë³¸)
@@ -318,6 +318,7 @@ _desc_init(void)
ELM_CONFIG_VAL(D, T, desktop_entry, T_UCHAR);
ELM_CONFIG_VAL(D, T, password_show_last, T_UCHAR);
ELM_CONFIG_VAL(D, T, password_show_last_timeout, T_DOUBLE);
+ ELM_CONFIG_VAL(D, T, glayer_zoom_finger_enable, T_UCHAR);
ELM_CONFIG_VAL(D, T, glayer_zoom_finger_factor, T_DOUBLE);
ELM_CONFIG_VAL(D, T, glayer_zoom_wheel_factor, T_DOUBLE);
ELM_CONFIG_VAL(D, T, glayer_zoom_distance_tolerance, T_DOUBLE);
@@ -887,6 +888,7 @@ _config_load(void)
_elm_config->is_mirrored = EINA_FALSE; /* Read sys value in env_get() */
_elm_config->password_show_last = EINA_FALSE;
_elm_config->password_show_last_timeout = 2.0;
+ _elm_config->glayer_zoom_finger_enable = EINA_FALSE;
_elm_config->glayer_zoom_finger_factor = 1.0;
_elm_config->glayer_zoom_wheel_factor = 0.05;
_elm_config->glayer_zoom_distance_tolerance = 1.0; /* 1 times elm_finger_size_get() */
Index: src/lib/elm_map.c
===================================================================
--- src/lib/elm_map.c (리ë¹ì 66265)
+++ src/lib/elm_map.c (ìì
ì¬ë³¸)
@@ -3223,12 +3223,15 @@ elm_map_add(Evas_Object *parent)
_mouse_move, obj);
evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MOUSE_UP,
_mouse_up, obj);
- evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_DOWN,
- _mouse_multi_down, obj);
- evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_MOVE,
- _mouse_multi_move, obj);
- evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_UP,
- _mouse_multi_up, obj);
+ if (_elm_config->glayer_zoom_finger_enable)
+ {
+ evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_DOWN,
+ _mouse_multi_down, obj);
+ evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_MOVE,
+ _mouse_multi_move, obj);
+ evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_UP,
+ _mouse_multi_up, obj);
+ }
evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MOUSE_WHEEL,
_mouse_wheel_cb, obj);
Index: src/lib/elm_gesture_layer.c
===================================================================
--- src/lib/elm_gesture_layer.c (리ë¹ì 66265)
+++ src/lib/elm_gesture_layer.c (ìì
ì¬ë³¸)
@@ -3327,6 +3327,12 @@ elm_gesture_layer_cb_set(Evas_Object *ob
Gesture_Info *p;
if (!wd) return;
+ if (!_elm_config->glayer_zoom_finger_enable && idx == ELM_GESTURE_ZOOM)
+ {
+ ERR("Finger(pinch) zoom is disabled for some reasons such as patent issues. if you want enable it, you should change glayer_zoom_finger_enable value in elementary configuration");
+ return;
+ }
+
if (!wd->gesture[idx])
wd->gesture[idx] = calloc(1, sizeof(Gesture_Info));
if (!wd->gesture[idx]) return;
Index: src/lib/elm_priv.h
===================================================================
--- src/lib/elm_priv.h (리ë¹ì 66265)
+++ src/lib/elm_priv.h (ìì
ì¬ë³¸)
@@ -149,6 +149,7 @@ struct _Elm_Config
unsigned char desktop_entry;
Eina_Bool password_show_last;
double password_show_last_timeout;
+ Eina_Bool glayer_zoom_finger_enable;
double glayer_zoom_finger_factor;
double glayer_zoom_wheel_factor;
double glayer_zoom_distance_tolerance;
Index: config/standard/base.src
===================================================================
--- config/standard/base.src (리ë¹ì 66265)
+++ config/standard/base.src (ìì
ì¬ë³¸)
@@ -44,6 +44,7 @@ group "Elm_Config" struct {
value "desktop_entry" uchar: 1;
value "password_show_last" uchar: 0;
value "password_show_last_timeout" double: 2.0;
+ value "glayer_zoom_finger_enable" uchar: 0;
value "glayer_zoom_finger_factor" double: 1.0;
value "glayer_zoom_wheel_factor" double: 0.05;
value "glayer_zoom_distance_tolerance" double: 1.0;
Index: config/default/base.src
===================================================================
--- config/default/base.src (리ë¹ì 66265)
+++ config/default/base.src (ìì
ì¬ë³¸)
@@ -40,6 +40,7 @@ group "Elm_Config" struct {
value "desktop_entry" uchar: 0;
value "password_show_last" uchar: 0;
value "password_show_last_timeout" double: 2.0;
+ value "glayer_zoom_finger_enable" uchar: 0;
value "glayer_zoom_finger_factor" double: 1.0;
value "glayer_zoom_wheel_factor" double: 0.05;
value "glayer_zoom_distance_tolerance" double: 1.0;
Index: config/illume/base.src
===================================================================
--- config/illume/base.src (리ë¹ì 66265)
+++ config/illume/base.src (ìì
ì¬ë³¸)
@@ -44,6 +44,7 @@ group "Elm_Config" struct {
value "desktop_entry" uchar: 0;
value "password_show_last" uchar: 1;
value "password_show_last_timeout" double: 2.0;
+ value "glayer_zoom_finger_enable" uchar: 0;
value "glayer_zoom_finger_factor" double: 1.0;
value "glayer_zoom_wheel_factor" double: 0.05;
value "glayer_zoom_distance_tolerance" double: 1.0;
------------------------------------------------------------------------------
Learn Windows Azure Live! Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for
developers. It will provide a great way to learn Windows Azure and what it
provides. You can attend the event by watching it streamed LIVE online.
Learn more at http://p.sf.net/sfu/ms-windowsazure
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
