Dear Cedric,
Well said.
Silencing warnings just for silencing is not good. We use them to spot
bugs, that's why we like them so much. Silencing useful warnings is
counter-productive.
--
Tom.
On 21/03/13 01:12, Cedric BAIL - Enlightenment Git wrote:
> cedric pushed a commit to branch master.
>
> commit 07b5d9fe6ca5137e0a4c837d0fab5839a0ba50ee
> Author: Cedric BAIL <cedric.b...@samsung.com>
> Date: Thu Mar 21 10:04:32 2013 +0900
>
> dear Mike,
>
> If you just want to silence your warning remove all -W from your CFLAGS
> and
> take your revenge back to your compiler. Introducing bugs to just silent
> warning
> is not gona help any one.
>
> The borker,
> Cedric
> ---
> src/bin/e_sys_l2ping.c | 3 ++-
> src/bin/e_sys_main.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/bin/e_sys_l2ping.c b/src/bin/e_sys_l2ping.c
> index faab77e..236364d 100644
> --- a/src/bin/e_sys_l2ping.c
> +++ b/src/bin/e_sys_l2ping.c
> @@ -10,7 +10,7 @@
> #endif
>
> double
> -e_sys_l2ping(const char *bluetooth_mac EINA_UNUSED)
> +e_sys_l2ping(const char *bluetooth_mac)
> {
> #ifdef HAVE_BLUETOOTH
> char send_buf[L2CAP_CMD_HDR_SIZE + 1];
> @@ -95,6 +95,7 @@ e_sys_l2ping(const char *bluetooth_mac EINA_UNUSED)
>
> return ecore_time_get() - start;
> #else
> + (void) bluetooth_mac;
> fprintf(stderr, "e_sys_l2ping nop\n");
> return -1;
> #endif
> diff --git a/src/bin/e_sys_main.c b/src/bin/e_sys_main.c
> index 70f836c..b48f1c0 100644
> --- a/src/bin/e_sys_main.c
> +++ b/src/bin/e_sys_main.c
> @@ -188,7 +188,7 @@ main(int argc,
> latency = e_sys_l2ping(output);
>
> eina_convert_dtoa(latency, tmp);
> - fprintf(stdout, "%s\n", tmp);
> + fputs(tmp, stdout);
>
> return (latency < 0) ? 1 : 0;
> }
>
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
