On Tue, 16 Apr 2013 16:24:08 -0300 Lucas De Marchi <[email protected]> said:
> On Tue, Apr 16, 2013 at 4:13 PM, <[email protected]> wrote: > > Tom Hacohen <[email protected]> wrote: > >> > >> On 16/04/13 16:01, Lucas De Marchi wrote: > >>> > >>> On Tue, Apr 16, 2013 at 11:54 AM, Tom Hacohen <[email protected]> > >>> wrote: > >>>> > >>>> On 16/04/13 15:26, Lucas De Marchi wrote: > >>>> > >>>>> On Tue, Apr 16, 2013 at 11:12 AM, Tom Hacohen <[email protected]> > >>>>> wrote: > >>>>> > >>>>>> Hey guys, > >>>>>> > >>>>>> How are you? I just noticed that 'edbus' installs headers under: > >>>>>> prefix/include/edbus-1 > >>>>>> while using the > >>>>>> pkgconfig name 'edbus2' > >>>>>> the library name 'libedbus2' > >>>>>> and an header called 'EDbus.h'. > >>>>>> > >>>>>> Luckily for us, it's not too late to fix it. Only question, what > >>>>>> should > >>>>>> we > >>>>>> change it to? Everywhere with the 2 or everywhere without the 2? > >>>>> > >>>>> > >>>>> > >>>>> E_DBus installed edbus.pc and libedbus.so - that's why we needed to > >>>>> put a 2 in the name. > >>>>> > >>>>> However the name is edbus and has no relations with the previous > >>>>> library. It's not a new version, it's a complete different one. So > >>>>> appending a "2" in headers and include path is the wrong thing to do. > >>>>> > >>>>> If ebus was available I would vote for that. It seems we are short in > >>>>> options for names. > >>>>> > >>>>> Lucas De Marchi > >>>> > >>>> > >>>> > >>>> > >>>> I understand putting the 2 was needed, but if we add it once, we should > >>>> add > >>>> it everywhere. It's annoyingly inconsistent. > >>>> > >>>> Why did you choose 2 then? Why not 4? Or A? You chose 2 because > >>>> it's the > >>>> best explanation, as it is, although mostly unrelated, e_dbus v2. And if > >>> > >>> > >>> because it was not me is the best explanation. > >>> > >>>> that's good enough there, it's good enough everywhere. > >>>> > >>>> In conclusion, I see no harm in using edbus2 all around the place. > >>> > >>> > >>> it's not good enough there, even less everywhere. The visible part to > >>> the developer is the include path and the namespace. And these should > >>> reflect the library name. If anything change everything to something > >>> else, but don't put the 2 there. > >> > >> > >> > >> Let's wait to see what others think, as we disagree about the source of > >> the problem, and that's: is this a major inconsistency that should be > >> solved. > >> > >> Anyhow, regarding different names: I suggest edbus2. > >> > >> -- > >> Tom. > >> > >> > >> ________________________________ > >> > >> Precog is a next-generation analytics platform capable of advanced > >> analytics on semi-structured data. The platform includes APIs for building > >> apps and a phenomenal toolset for data science. Developers can use > >> our toolset for easy data analysis & visualization. Get a free account! > >> http://www2.precog.com/precogplatform/slashdotnewsletter > >> ________________________________ > >> > >> enlightenment-devel mailing list > >> [email protected] > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > I agree with whatever demarchi says. > > I disagree. > > > oh, wait... > > Lucas De Marchi :-P ... i have to say though - consistency is good. not just for devs, but packagers and anyone looking at their filesystem. if things are named in a consistent pattern it is easy to know what belongs where without needing package databases or other forensics tools. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
