On Tue, 30 Apr 2013 15:15:05 +0100 Tom Hacohen <tom.haco...@samsung.com> said:

> Where did you get that on?
> Anyhow, what do you think about changing it to unsigned wchar_t?

on my pentium-m test machine... unicode val 0 was < 0 and thus walked below the
array. yes. literally a negative.  wouldnt that be wuchar_t or something? as
wchar_t .. is a typedef... :)

> --
> Tom.
> 
> On 30/04/13 15:11, Carsten Haitzler - Enlightenment Git (Rasterman) wrote:
> > raster pushed a commit to branch master.
> >
> > commit ab0fdf5916757d9f30c606ef464f10852d7fa42d
> > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
> > Date:   Tue Apr 30 23:10:24 2013 +0900
> >
> >      it is possible with wchart_t to have it signed.. so unicode can be <
> >      0... dont crash.
> > ---
> >   src/lib/evas/common/language/evas_language_utils.c | 7 +++++--
> >   1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/lib/evas/common/language/evas_language_utils.c
> > b/src/lib/evas/common/language/evas_language_utils.c index a7b8ef0..23dfb53
> > 100644
> > --- a/src/lib/evas/common/language/evas_language_utils.c
> > +++ b/src/lib/evas/common/language/evas_language_utils.c
> > @@ -1,3 +1,6 @@
> > +
> > +
> > +
> >   /**
> >    * @internal
> >    * @addtogroup Evas_Utils
> > @@ -59,10 +62,10 @@ _evas_common_language_char_script_search(Eina_Unicode
> > unicode) Evas_Script_Type
> >   evas_common_language_char_script_get(Eina_Unicode unicode)
> >   {
> > +   if (unicode < 0) return EVAS_SCRIPT_COMMON;
> >      if (unicode < EVAS_SCRIPT_DIRECT_TABLE_LIMIT)
> >         return _evas_script_fast_table[unicode];
> > -   else
> > -      return _evas_common_language_char_script_search(unicode);
> > +   return _evas_common_language_char_script_search(unicode);
> >   }
> >
> >   int
> >
> 
> 
> ------------------------------------------------------------------------------
> Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
> Get 100% visibility into your production application - at no cost.
> Code-level diagnostics for performance bottlenecks with <2% overhead
> Download for free and get started troubleshooting in minutes.
> http://p.sf.net/sfu/appdyn_d2d_ap1
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to