2014-12-31 19:31 GMT+01:00 Thanatermesis <thanatermesis.e...@gmail.com>:
> Right, there's also the case of /usr/local which i have not considered > (only /usr and /usr/local), so this updated patch fixes it: > > http://pastebin.com/1Nn4rETD > > by other side these trailing slashes seems like to be made wrongly by your > OS creating the XDG_DATA_DIRS variable, they should not include trailing > slashes, maybe we should remove the possible trailing slashes from the > variable get > > I still think that harcoding a path is always the wrong solution, looking at that file seems to me that the real problem is some line below, in the else: snprintf(buf, sizeof(buf), "%s:/usr/local/share:/usr/share", newpath); Why we are blindly adding /usr/share and /usr/loca/share here ?? plus newpath, that can include the same ?? this seems the real source of the problem, but I'm not in touch with that code, I cannot really understand what was the intention here :/ > > 2014-12-31 3:26 GMT+01:00 Jean-Philippe André <j...@videolan.org>: > > > Hi, > > > > > > On Wed, Dec 31, 2014 at 3:04 AM, Davide Andreoli <d...@gurumeditation.it > > > > wrote: > > > > > 2014-12-30 16:57 GMT+01:00 Thanatermesis <thanatermesis.e...@gmail.com > >: > > > > > > > Back from some holidays (more or less) > > > > > > > > My previous patch was wrong, since strcmp returns the inverse of > what I > > > > expected (zero if success), so this is the correct one: > > > > > > > > http://pastebin.com/xDj755cL > > > > > > > > Should I push it to master? > > > > > > > > > > This patch seems not the correct approach to me... why you don't add if > > the > > > prefix is /usr? > > > Because you are assuming /usr is the default on the user system? > > > > > > Also look at my $XDG_DATA_DIRS: > > > > > > > > > /usr/local/share/enlightenment:/usr/local/share:/usr/local/share/:/usr/share/ > > > ... > > > > > > here /usr/local/share is added twice(with and without trailing slash), > so > > > your patch will not solve my case. > > > > > > I think you should really check in another way :/ > > > > > > > Right, that was my suspicion, that assuming /usr was not the best idea. > > I guess maybe just strstr() over the the existing value so as to not > > prepend anything that's already there. Or prepend and remove the previous > > entry. Dunno. :) > > > > > > Best regards, > > > > > > > > > > > > > > > > > > > > > > > > > > > 2014-12-24 13:34 GMT+01:00 Thanatermesis < > thanatermesis.e...@gmail.com > > >: > > > > > > > > > > Not sure how you got /usr/share to be duplicated, it is not the > > case > > > > > here... > > > > > > > > > > That's exactly what my patch does :), as: > > > > > > > > > > > % echo $XDG_DATA_DIRS | tr ':' '\n' | sort > > > > > > /opt/e/share > > > > > > /opt/e/share/enlightenment > > > > > > /usr/local/share > > > > > > /usr/share > > > > > > > > > > for your case, since you don't have /usr as default prefix it > doesn't > > > > bugs > > > > > to you, but /usr is the most common prefix, the bug happens only > > when > > > > the > > > > > default prefix is /usr, by adding it before is added statically (as > > > like > > > > in > > > > > your last line) > > > > > > > > > > > Also, you should remove 'p' in the first snprintf line :) > > > > > > > > > > right! corrected in another commit: http://pastebin.com/xrB51sXW > > > > > > > > > > > So... is it really bad to have duplicates in XDG_DATA_DIRS? > > > > > > > > > > first, .desktop files would appear in the wrong order (overwrite > one > > by > > > > > other, priority listing of them), also it may probably increase > twice > > > > > the amount of processed data (.desktop files scanning, which almost > > all > > > > are > > > > > in /usr/share), and there's also a small bug that icons changes > from > > > one > > > > to > > > > > other very fastly when you do alt-tab, but i dont know from where > > this > > > > bug > > > > > comes from, it can be related :) > > > > > > > > > > > > > > > > > > > > 2014-12-24 2:16 GMT+01:00 Jean-Philippe André <j...@videolan.org>: > > > > > > > > > >> Hi, > > > > >> > > > > >> Not sure how you got /usr/share to be duplicated, it is not the > case > > > > >> here... > > > > >> > > > > >> On Wed, Dec 24, 2014 at 1:13 AM, Thanatermesis < > > > > >> thanatermesis.e...@gmail.com > > > > >> > wrote: > > > > >> > > > > >> > If you run: > > > > >> > > > > > >> > echo $XDG_DATA_DIRS | tr ':' '\n' | sort > > > > >> > > > > > >> > you will see that you have a duplicated one > > > > >> > > > > > >> > > > > >> % echo $XDG_DATA_DIRS | tr ':' '\n' | sort > > > > >> /opt/e/share > > > > >> /opt/e/share/enlightenment > > > > >> /usr/local/share > > > > >> /usr/share > > > > >> > > > > >> > > > > >> > > > > > >> > So I did this commit http://pastebin.com/9BUnzrHu which works > > on > > > > both > > > > >> > e17 > > > > >> > and master branches, where it fixes the problem, as we can see > in > > > > >> > https://www.enlightenment.org/ss/e-54998c1c35fdd0.34968942.jpg > > > > >> > > > > > >> > Lacking of time that somebody checks the commit before to do any > > > push > > > > I > > > > >> > ended to pushing it only to my own remote (everybody on > christmas? > > > > yeah > > > > >> i > > > > >> > should go too!) > > > > >> > > > > > >> > So... what do you think? I should push this commit? anything to > > > > change? > > > > >> > > > > > >> > > > > >> > > > > >> Did you have /usr as prefix for EFL but not for E? > > > > >> Also, you should remove 'p' in the first snprintf line :) > > > > >> > > > > >> So... is it really bad to have duplicates in XDG_DATA_DIRS? > > > > >> If it is, then something smarter than just checking for /usr > should > > > > >> probably be implemented. > > > > >> > > > > >> Best regards, > > > > >> > > > > >> -- > > > > >> Jean-Philippe André > > > > >> > > > > >> > > > > > > > > > > ------------------------------------------------------------------------------ > > > > >> Dive into the World of Parallel Programming! The Go Parallel > > Website, > > > > >> sponsored by Intel and developed in partnership with Slashdot > Media, > > > is > > > > >> your > > > > >> hub for all things parallel software development, from weekly > > thought > > > > >> leadership blogs to news, videos, case studies, tutorials and > more. > > > > Take a > > > > >> look and join the conversation now. > > http://goparallel.sourceforge.net > > > > >> _______________________________________________ > > > > >> enlightenment-devel mailing list > > > > >> enlightenment-devel@lists.sourceforge.net > > > > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > > Dive into the World of Parallel Programming! The Go Parallel Website, > > > > sponsored by Intel and developed in partnership with Slashdot Media, > is > > > > your > > > > hub for all things parallel software development, from weekly thought > > > > leadership blogs to news, videos, case studies, tutorials and more. > > Take > > > a > > > > look and join the conversation now. > http://goparallel.sourceforge.net > > > > _______________________________________________ > > > > enlightenment-devel mailing list > > > > enlightenment-devel@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Dive into the World of Parallel Programming! The Go Parallel Website, > > > sponsored by Intel and developed in partnership with Slashdot Media, is > > > your > > > hub for all things parallel software development, from weekly thought > > > leadership blogs to news, videos, case studies, tutorials and more. > Take > > a > > > look and join the conversation now. http://goparallel.sourceforge.net > > > _______________________________________________ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > -- > > Jean-Philippe André > > > > > ------------------------------------------------------------------------------ > > Dive into the World of Parallel Programming! The Go Parallel Website, > > sponsored by Intel and developed in partnership with Slashdot Media, is > > your > > hub for all things parallel software development, from weekly thought > > leadership blogs to news, videos, case studies, tutorials and more. Take > a > > look and join the conversation now. http://goparallel.sourceforge.net > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming! The Go Parallel Website, > sponsored by Intel and developed in partnership with Slashdot Media, is > your > hub for all things parallel software development, from weekly thought > leadership blogs to news, videos, case studies, tutorials and more. Take a > look and join the conversation now. http://goparallel.sourceforge.net > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming! The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
