Thankfully, it seems you didn't end up pushing your revert back upstream
and the issue is now resolved.

It would be great if we could step back from this "instant revert" culture
that has been created since the move to git. Just because it can be done
doesn't mean that it should; it's a very reasonable thing to do a local
revert (like this) and then raise an issue about the commit in question.
This preserves repository history and makes it significantly easier to
bisect things when there are fewer "revert XYZ" -> "revert 'revert XYZ'"
chains needing to be followed.

On Fri, Jun 26, 2015 at 3:34 AM, Carsten Haitzler <ras...@rasterman.com>
wrote:

> On Thu, 25 Jun 2015 17:30:43 -0700 Mike Blumenkrantz <
> zm...@osg.samsung.com>
> said:
>
> sorry - i had to revert this due to a pretty bad behavior bug this commit
> introduced. see my commit log in the revert. i pinged you on irc (zmike)
> but no
> response, so i've had to do this to at least keep e working until this can
> come
> back without this break. :]
>
> > discomfitor pushed a commit to branch master.
> >
> >
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=2b38147c43270815ef71726d8700703968429d90
> >
> > commit 2b38147c43270815ef71726d8700703968429d90
> > Author: Mike Blumenkrantz <zm...@osg.samsung.com>
> > Date:   Thu Jun 25 19:55:37 2015 -0400
> >
> >     add hooking for WL_SURFACE_ID atom on XWayland windows and composite
> them
> >
> >     in order to maximize the amount of reused code the following details
> the
> > current process for xwayland compositing:
> >
> >     * get map request from window
> >     * force reparenting
> >     * show window
> >     * await WL_SURFACE_ID x11 message
> >     * move x11 client data + pixmap onto corresponding wayland client
> >     * business as usual with wayland compositing
> >
> >     this is pretty similar to the method of the reference code in weston,
> >     except that there's no x11 compositor in weston
> > ---
> >  src/bin/e_comp_wl.c |  21 ++++++++--
> >  src/bin/e_comp_wl.h |  34 ++++++++++++++-
> >  src/bin/e_comp_x.c  | 119 ++++++++++++++++++++++++++++++++++++++++++++
> > +------- src/bin/e_comp_x.h  |   8 +++-
> >  4 files changed, 161 insertions(+), 21 deletions(-)
> >
>
------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors 
network devices and physical & virtual servers, alerts via email & sms 
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to