On Thu, Jan 7, 2016 at 1:09 AM, Jean-Philippe André <[email protected]> wrote: > On 7 January 2016 at 09:59, Cedric BAIL <[email protected]> wrote: >> On Tue, Jan 5, 2016 at 10:04 PM, Jean-Philippe André <[email protected]> >> wrote: >> > Recently a series of patches for Evas 3d and Evas VG have been merged in >> > (mostly by Cedric and myself), and add a bunch of new APIs as well as >> EAPI >> > symbols. >> > >> > I also accepted two patches and forgot to push them yesterday before the >> > freeze: >> > 1. 996d17bcc5a08e75f evas: Update Ector_Color structure >> > 2. d2bb0eefc4a2eb640 Evas 3d: Get hash table of scenes using the given >> node >> > as root. >> > >> > If you find them not acceptable for this release, please revert (patch 1. >> > is probably fine... but see below). >> > >> > >> > None of the Ector APIs are stable. >> > >> > >> > So, this raises a few questions: >> > - Should eina_vector{2,3} be static inline in the header instead of EAPI? >> > (less symbols) >> >> I think so. >> > > That's done (static inline, no EAPI) > Eina_Vector3 has not been merged in EFL. I guess this will wait until 1.18? > Or do we want them now for 1.17? (for consistency... but i don't like the > idea of rushing this in) > > See https://phab.enlightenment.org/D3527 > > (it still needs to be inlined anyway)
No need to rush that in I think, >> > - Should we even install the Ector headers? >> > > They are not installed anymore. So the next point must be fixed :) > > >> > - Should Ector_Color be Efl.Gfx.Color instead? Or Eina? (I argued myself >> > that color belonged to ector, but now I wonder, considering ector is not >> > stable) >> >> I have been thinking they should belong to Efl.Gfx.Color in fact as we >> do have API to set color in Efl.Gfx and it would make sense to make >> this compatible with that structure. I may do that change tomorrow if >> nobody raise their voice on the matter. > > Ok, I'll let you do that then. Thanks. I will land a patch shortly for that soon. -- Cedric BAIL ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
