On Mon, 22 Aug 2016 15:32:36 +0100 Tom Hacohen <t...@osg.samsung.com> said:
> On 19/08/16 05:35, Jean-Philippe André wrote: > > Hi Tom, > > > > On 16 August 2016 at 12:05, Jean-Philippe André <j...@videolan.org> wrote: > > > >> Hi, > >> > >> On 15 August 2016 at 23:21, Tom Hacohen <t...@osg.samsung.com> wrote: > >> > >>> Hey there, > >>> > >>> As agreed I've now moved Eo to the Efl namespace. There is only one > >>> thing left to rename and then I will be done. That remaining item is > >>> "Eo_Event". This is the extra parameter passed to the event callbacks > >>> that includes things like the event info, object and the event > >>> description. I was going to just rename it to Efl_Event, but > >>> unfortunately this is already taken by an interface. > >>> > >>> My options are now to either rename Efl_Event to something else, and > >>> then Eo_Event to that. Or just rename Eo_Event to something that doesn't > >>> clash. > >>> > >>> I'm not feeling very creative today and can't come up with a good name. > >>> I'm lazy, so I'd rather just rename Eo_Event to something that doesn't > >>> clash, but given that Eo_Event is used all over the place, and the other > >>> is rarely used, I'd rather keep the Eo_Event name short, call it > >>> Efl_Event and rename the other one. > >>> > >>> Any naming suggestions? > >>> > >>> > >> The question is more whether we want to use the Efl_Event interface for > >> more events than just input, as I did so far. > >> > >> For reference, Efl_Event interface has some methods targetted for the > >> event info structs: > >> - timestamp (common for all input events, and could be used for others) > >> - dup, reset and instance_get are here to reuse objects like in a cache, > >> or generate new events based on a previous one (dup) > >> > >> IOW I don't care if the name Efl_Event is used for Eo_Event. We could > >> rename the current Efl.Event into Efl.Event.Info for instance (since it's > >> the event->info object). > >> > > > > So, should I rename the class to Efl.Event.Info? > > I'd be happy with it, no problem. > > > > I guess that would be a start, though I think that's not the best of > names either. We can probably do better. :) all the current Efl_Event things are some kind of input event so Efl.Input ? -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
