Hi everyone On Mon, Apr 13, 2026 at 03:49:30PM +0200, Michael Niedermayer via ffmpeg-devel wrote: [...] > If the concern is mainly the way Fairy writes messages, that is adjustable. > She is writing in the style I asked for, and I can change the prompting. > If the tone feels too assertive or too strong, I can try to make it softer > and more neutral. That is just a matter of adjusting how the messages are > generated.
Do you prefer the tone / style of this one: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20971#issuecomment-36421 For reference: Thanks, this looks like a good start, but I think there are a couple of things to fix before approval: In 97e6eca06390, MATROSKA_ID_CHAPTERATOM was removed from matroska_chapter_entry[]. Previously nested ChapterAtom elements were treated as known but intentionally skipped. After this change they fall into the generic unknown-element path instead. That still skips them on the happy path, but on non-seekable inputs it also feeds the damaged-data heuristic (unknown_count / SKIP_THRESHOLD), so valid files with hierarchical chapters can now be treated as malformed. I think ChapterAtom should stay as EBML_NONE here unless subchapters are parsed properly. The forward-declaration block still contains matroska_chapter[6], but there is no matching real definition/use anymore after the rename to matroska_edition. That leaves an unused static object behind, which is likely to trigger a source warning with FFmpeg's warning setup (-Wall, while -Wno-unused-variable is only disabled for headers) . If you already have the sample you mentioned locally, a small FATE case covering EditionEntry plus a nested ChapterAtom would also make this much safer. -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "Nothing to hide" only works if the folks in power share the values of you and everyone you know entirely and always will -- Tom Scott
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
