On Wed, Aug 22, 2018 at 10:20:53AM +0200, Martin Vignali wrote: > > > > > So the only thing I can do is to disable these tests for > > > these formats. > > > Otherwise, I need to test other changes somehow. Here is the patch, that > > > skips > > > pixfmts tests for these formats. > > > > in absence of another solution this should be ok > > > > > I'm not against, removing these tests for now, >
> But maybe to make tests simpler, we can use/add bit exact conversion > for uint8 to float, we can generate a LUT without float calc > and for uint16 to float, we can add a uint16 to float conversion without > float calc, or maybe, generate a LUT in bit exact mode (probably faster, if > it's acceptable to have a LUT for 16bit entries) I think before you design everything around a non float based convertion it would make sense to evaluate the speed of SIMD for the convertion. so all the choices are understood > > If the bit exact mode is much slower than the "float" version we can keep > both, this is possible, it is not ideal though as the tested and used in practice code path differs then. Of course a bit exact version does make sense either way. As some people probably want scaling to be bitexact > in order to use the bit exact for various tests > and use it as reference in order to compare bit exact and "float" conv for > each func. > > I can send patch for this, if need. > > Martin > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that one is less smart then the original author, trying to rewrite it will not make it better.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel