On 9/20/2014 8:20 PM, Kevin Horton wrote: > On Sep 20, 2014, at 20:00 , Hanspeter Niederstrasser <f...@snaggledworks.com> > wrote: >> >> On 9/20/2014 6:44 PM, Kevin Horton wrote: >>> >>>> On Sep 20, 2014, at 17:42 , Hanspeter Niederstrasser >>>> <hanspe...@snaggledworks.com> wrote: >>>> >>>> Dear Fink developers: >>>> >>>> The recent buildworld run did not validate the .info and .deb files. I've >>>> manually run the builworld debs through the validator and the following >>>> debs came out with errors: >>>> >>>> Validating .deb file graphics/aquaterm-shlibs_1.1.1-2_darwin-x86_64.deb... >>>> Error: Framework files not part of a specific library-version, but package >>>> does not declare BuildDependsOnly to be true (or false) >>>> Offending file: /sw/Library/Frameworks/AquaTerm.framework/AquaTerm >>>> Offending file: /sw/Library/Frameworks/AquaTerm.framework/Headers/ >>>> Offending file: /sw/Library/Frameworks/AquaTerm.framework/Resources/ >>>> Offending file: >>>> /sw/Library/Frameworks/AquaTerm.framework/Versions/Current/ >>>> >>>> >>>> Hanspeter >>> >>> I need some assistance resolving the reported validation issues with the >>> aquaterm package. >>> >>> 1. Hanspeter - I don’t get the above errors when I build the package in >>> maintainer mode, using fink 0.37.0. What validation test are you running? >>> In the future, I’d hope to catch these issues myself, before I release a >>> package. >>> >>> 2. Reading the error message, and reviewing the Packaging Manual, it looks >>> like I could avoid the error by adding “BuildDependsOnly: False”. But, I >>> don’t understand the implications of doing that, nor do I know what I >>> should write in the DescPackaging field. Or, is there a way to fix the >>> root problem, rather than putting a bandage over the error? >> >> 1) I'm using a validator test that just went into git HEAD: >> https://github.com/fink/fink/commit/c47d5780ba1b4d0954d1a655d6e2c6afd235e757 >> >> 2) The proper fix is to move files in unversioned directories (those >> marked as offending above) to the BuildDependsOnly aquaterm-dev package. >> Bump %r to 3 or higher, and add "Replaces: aquaterm-shlibs (<= 1.1.1-2)" >> to the -dev SplitOff so that the new aquaterm-dev-1.1.1-3 package can >> overwrite the now overlapping files from the old aquaterm-shlibs_1.1.1-2 >> package. You can see what I did to qt4-base-mac to fix the same error >> for comparison: >> <http://fink.cvs.sourceforge.net/viewvc/fink/dists/10.7/stable/main/finkinfo/libs/qt4-base-mac.info?r1=1.13&r2=1.14> >> > > The validator is complaining about everything that is in the framework - > every single top level directory! All its complaints are about the symlinks > that contain the whole of the framework, including the portions that are > declared as shlibs. Is none of the framework required during run time? I’d > run that test myself, but so far I’ve failed to craft an updated info file > that installs without error.
The following patch works for me. It leaves behind in the aquaterm-shlibs SplitOff only the file that is in the Shlibs field. I'm actually not 100% sure that lib/libaquaterm.*.dylib belongs there either, since it's a convenience buildtime symlink to the real install_name file. ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< Index: aquaterm.info =================================================================== RCS file: /cvsroot/fink/dists/10.7/stable/main/finkinfo/graphics/aquaterm.info,v retrieving revision 1.5 diff -u -U8 -r1.5 aquaterm.info --- aquaterm.info 23 Oct 2013 14:37:50 -0000 1.5 +++ aquaterm.info 21 Sep 2014 01:29:24 -0000 @@ -1,11 +1,11 @@ Package: aquaterm Version: 1.1.1 -Revision: 2 +Revision: 3 Source: http://www.kilohotel.com/fink/AquaTerm-%v.tar.gz Source-MD5: 9c8da40bda38f4b9f3a57e560fdd9b5c BuildDepends: xcode.app Depends: %N-shlibs (= %v-%r) GCC: 4.0 SourceDirectory: AquaTerm-AquaTerm-5c223a5 PatchFile: %n.patch PatchFile-MD5: 94fb89d7b6eab5dc76da57fd4f7d5194 @@ -26,28 +26,40 @@ mkdir -p %i/share/%n cp -p -R ../adapters %i/share/%n chmod u+w %i/Library/Frameworks/AquaTerm.framework chmod u+w %i/Library/Frameworks/AquaTerm.framework/Versions << SplitOff: << Package: %N-shlibs Replaces: %N (<= 1.0-1) - Files: Library lib/libaquaterm.*.dylib + Files: << + Library/Frameworks/AquaTerm.framework/Versions/A/AquaTerm + lib/libaquaterm.*.dylib + << Shlibs: << %p/Library/Frameworks/AquaTerm.framework/Versions/A/AquaTerm 1.0.0 %n (>= 1.0.0-1) << DocFiles: aquaterm/ReadMe aquaterm/ReleaseNotes aquaterm/INSTALL << SplitOff2: << Package: %N-dev BuildDependsOnly: True Depends: %N-shlibs (= %v-%r) - Replaces: %N (<= 1.0-1) - Files: include lib/libaquaterm.dylib share/%N + Replaces: %N (<= 1.0-1), %N-shlibs (<= 1.1.1-2) + Files: << + Library/Frameworks/AquaTerm.framework/AquaTerm + Library/Frameworks/AquaTerm.framework/Headers + Library/Frameworks/AquaTerm.framework/Resources + Library/Frameworks/AquaTerm.framework/Versions/Current + Library/Frameworks/AquaTerm.framework/Versions/A/Headers + include + lib/libaquaterm.dylib + share/%N + << DocFiles: aquaterm/ReadMe aquaterm/ReleaseNotes aquaterm/INSTALL << DocFiles: aquaterm/ReadMe aquaterm/ReleaseNotes aquaterm/INSTALL aquaterm/Help/*.html License: OSI-Approved Description: Displays vector graphics in Aqua DescPackaging: << Package previously maintained by Jeffrey Whitaker. Package ownership assumed by Kevin Horton as of aquaterm-1.0.1-5. ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< Hanspeter ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that Matters. http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk _______________________________________________ Fink-devel mailing list Fink-devel@lists.sourceforge.net List archive: http://news.gmane.org/gmane.os.apple.fink.devel Subscription management: https://lists.sourceforge.net/lists/listinfo/fink-devel
