On Wed, Jan 25, 2017 at 7:26 PM, David B. Lamkins <da...@lamkins.net> wrote:

> Just to be clear, I'm doing
>
> > git checkout f4476100
>
> That looks like the head of a branch, iothread_perform_lambda, that has
> several other commits.
>

Huh? After I do that checkout running `git log --stat -100` reports the
following. I think you are being confused by ridiculousfish's propensity to
let his private branches bleed into the github repo. In this case
https://github.com/fish-shell/fish-shell/commits/iothread_perform_lambda.
Ignore that he was working on a private branch. It isn't relevant. What is
relevant is that the change you're fixated on does nothing other than
change a comment. From `git log -p -1 f4476100`:

commit f4476100f28880e7fad660fefed118ef2521633c
Author: ridiculousfish <corydo...@ridiculousfish.com>
Date:   Sun Jan 22 00:59:50 2017 -0800

    Remove comment about job_iterator_t being used from signal handlers

    It is no longer used from signal handlers, and has not been for a while

diff --git a/src/proc.h b/src/proc.h
index 9d0508f1..7990174d 100644
--- a/src/proc.h
+++ b/src/proc.h
@@ -249,8 +249,7 @@ typedef std::list<job_t *> job_list_t;

 bool job_list_is_empty(void);

-/// A class to aid iteration over jobs list. Note this is used from a
signal handler, so
-/// careful to not allocate memory.
+/// A class to aid iteration over jobs list
 class job_iterator_t {
     job_list_t *const job_list;
     job_list_t::iterator current, end;


-- 
Kurtis Rader
Caretaker of the exceptional canines Junior and Hank
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Fish-users mailing list
Fish-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fish-users

Reply via email to