Op 20-04-15 om 18:45 schreef lvqcl: > Well, the code in process_subframe_() calculates MAX value of > qlp_coeff_precision, > while the code in evaluate_lpc_subframe_() adjusts CURRENT > qlp_coeff_precision.
Yes, but that MAX value is used to loop over the qlp_coeff_precision values between MIN and MAX. So, if the qlp_coeff_precision value is limited in the loop but MAX is not limited, the loop does the exact same thing multiple times: a waste of time. Therefore, only the MAX should be limited. I don't think the logic is needed directly after > min_qlp_coeff_precision = max_qlp_coeff_precision = > encoder->protected_->qlp_coeff_precision; because that value is either chosen by the encoder (it is a lookup value, and is always small enough not to trigger this, set in stream_encoder.c around line 700) or it is set through the encoder, in which case it should probably not be overriden without notice. _______________________________________________ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev