On Tue, 5 Apr 2011 23:43:43 +0200 Stefan Reinauer <[email protected]> wrote:
> > +#define SSFS_AEL 0x00000010 /* Access Error > > Log */ +#define SSFS_AEL_OFF 4 > > Would be nice to > > #define SSFS_AEL (1 << SSFS_AEL_OFF) > > and so on. If both are needed. It would be nicer to get rid of either. yes, i would have defined the offsets only in the first place (without the _OFF suffix) and used a shift (or function macro) to create the masks where needed. refrained from that (bigger change) because i wanted feedback first. would that be ok? what is preferred? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
