Unfortunately, Tiago's particle system was committed with an
IMHO suboptimal XML interface. I suggested some changes and
Tiago agreed, but he then dropped off the list without
implementing them. I'd like to do that myself now, and I'll
adjust all uses of particle systems afterwards (later today
and if necessary tomorrow).


(1) <condition> was a child of <counter>, which is an
    implementation detail that shouldn't be exposed to the
    interface. --> move it to top level, like in all other
    cases where we use conditions. We want to turn the whole
    particle system on/off, after all, not just a counter
    (even if the c++ code does the latter).

(2) change  <rotspeed>  -->   <rotation-speed>
    change  <pps>       -->   <particles-per-sec>

(3) change <startsize>/<endsize>/<startcolor>/<endcolor> to
    <start>
        <color>
        <size>
    <end>
        <color>
        <size>

(4) turn <wind> and <gravity> from string properties that can
    either be "disabled" or "enabled" to bool properties.


To reviewers: please ensure sane interfaces before committing.
This is quite hard to fix later on (see submodel mess).

m.

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to