On Monday, April 18, 2011 20:51:17 ThorstenB wrote:

> And you also checked that approach glide angle isn't used? Otherwise,
> the new default cruise angle (0.0) might not match the original approach
> angle setting...
> 

No mention of approach glide angle either. I have no idea how this applies to 
rotorcraft since I only dug into the traditional "winged" code. A quick search 
through fgdata/Aircraft revealed the following aircraft to have different 
glide angles specified for approach and cruise:
- ASK13
- ASK21
- ASK21-MI
- IAR80 (fixed by Emilian I believe)
- PaperAirplane
ASK13 and PaperAirplane have the biggest difference between the two numbers 
(23 vs 2).
The fuel is a different matter, a very large number of aircraft have numbers 
other than default.
As far as the solver is concerned, the glide angle has a very large influence 
on the coefficients, while the fuel has a relatively small relevance in the 
final numbers.
Adding a tag which would be used on the new models could retain compatibility 
for older aircraft which are no longer developed. On the other hand, it would 
be a pity to have the very clean code of YASim cluttered by special cases for 
bugs. It's a tough choice, your call I guess.

Adrian


> Anyway, we've committed the patch since it was assumed to not cause
> major differences. These bugs have been there since the beginning of
> YASim - so for 10+ years.
> If it's confirmed that the patch actually caused major differences, then
> we should "improve" the patch. We could restore the old "buggy"
> behaviour by default and only use the new "correct" FDM configuration
> behaviour for new FDMs, e.g. add a switch, such as a new FDM parameter
> or YASim FDM version number in the xml file to enable the bugfix.
> 
> Heiko, and anyone else: if you think there is a major change, then
> directly compare the FDM behaviour with and without the patch - and let
> us know if there was trouble.
> 
> And that's the relevant patch:
> http://www.gitorious.org/fg/flightgear/commit/7f5a0e35184677c21f1eafdfbe643
> 8eb644cdbff
> 
> cheers,
> Thorsten
> 
> ---------------------------------------------------------------------------
> --- Benefiting from Server Virtualization: Beyond Initial Workload
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve
> application availability and disaster protection. Learn more about boosting
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> _______________________________________________
> Flightgear-devel mailing list
> Flightgear-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/flightgear-devel

------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to