I agree that all instances of #if FLTK_ABI_VERSION >= 10302 should be changed to #if FLTK_ABI_VERSION >= 10301.
About the #define FLTK_ABI_VERSION line of Enumerations.H : it's presently commented out. It should remain so, so default compiles don't include ABI-breaking features. Users who want to access those new features must uncomment it and recompile the whole library. Just like elsewhere, 10302 should be replaced by 10301. The Enumerations.H line should thus become: //#define FLTK_ABI_VERSION 10301 > Albrecht brought this up, and want him to check what I write here, > but I think what this is about is a few things; before releasing 1.3.1, > we need to change this line in Enumerations.H: > > #define FLTK_ABI_VERSION 10302 > > ..to either be commented out, or set to: > > #define FLTK_ABI_VERSION 10300 > > ..so that all ABI breaking features are off by default, so that > a default build will be binary compatible with 1.3.0 release > (ie. DLL compatibility). > > The reason it's set to 10302 now is so that svn devs can be testing > the new ABI breaking features, but we don't want those to be > enabled during "patch" releases (e.g. 1.3.0 -> 1.3.1), > only "minor" releases (e.g. 1.3 -> 1.4). > > So after 1.3.1 goes out, we'd switch FLTK_ABI_VERSION back to 10302 > so that all new ABI breaking features added will be 1.3.2 features. > > Not sure, but I think we may /also/ need to change all instances > of tests for FLTK_ABI_VERSION that currently refer to "10302" > and change them instead to 10301, eg: > > BEFORE: #if FLTK_ABI_VERSION >= 10302 > AFTER: #if FLTK_ABI_VERSION >= 10301 > > BEFORE: #if FLTK_ABI_VERSION < 10302 > AFTER: #if FLTK_ABI_VERSION < 10301 > > I /think/ 10302 was used is because 1.3.1 was slated to be a > micro-release > to fix a very specific problem in 1.3.0, and so 1.3.2 was going to be a > regular multiple features/fixes release. But since that 1.3.1 micro > release > never happened, 1.3.1 is going to be a regular patch release. > > So we should change the ABI macros from 10302 -> 10301 to reflect that > the ABI breaking features implemented so far are 1.3.1 compatible (and > off by default) > > FWIW, the CMP docs on FLTK_ABI_VERSION: > http://fltk.org/cmp.php#FLTK_ABI_VERSION > > Albrecht, does that all sound right? _______________________________________________ fltk-dev mailing list fltk-dev@easysw.com http://lists.easysw.com/mailman/listinfo/fltk-dev
