Some feedback on the patch:

I haven't tried all the features yet, but the legato and portamento work. The portamento time seems problematic however. I configured the pitch-bend up control on the EWI to give portamento time, and I found that I had to have the gain on the control very low (1 out of 127) to get portamento times of around 1/2 second (note that this is the instrument GAIN, not the actual values sent) . This is much longer than what I experience using a Roland synth. I'm wondering if there is some multiplier in the patch which is an order of magnitude too large? I don't know what numbers the control is sending, but I will investigate further.

What is it supposed to do? CC5 at 127 gives how much portamento time??

Ben

On 15/08/16 09:45, Ceresa Jean-Jacques wrote:

Hi, Ben

Thanks for your efforts. Anyway, i recommend using the full tree patched because

somes minor comments haved been added in the source (only comments not code).

For the future , i will iterate the same way. This is by far the best method.

Please at the time of make command, be vigilant. Always save the result of the build in a log.

It can be very useful in case of issue on RPi2. Really i dont' think you will get issue!

As you are a monophonic player, you will able to evaluate the enhanced legato modes.

your feedback is welcome.

regards

jjc

    > Message du 14/08/16 01:29
    > De : "Ben Gonzales" <b...@gonzos.net>
    > A : "FluidSynth mailing list" <fluid-dev@nongnu.org>
    > Copie à :
    > Objet : Re: [fluid-dev] New Patch 0003 - polymono - functionality
    >
    > Hi
    >
    > I edited the patch file to change the "\" to "/" in the
    filenames. I know I didn't need to because you have supplied the
    file tree, but I wanted to find out if that was the problem.
    Unfortunately I couldn't do a global search and replace as there
    are other "\"s that are valid.
    >
    > I can confirm that for the RPi, and I assume for all *nix
    platforms too, the change fixed the problem.
    >
    > The edited patch file is attached.
    >
    > Ben
    >
    >
    On 13/08/16 21:39, Ceresa Jean-Jacques wrote:
    >

        > Hi,

        >

        > To avoid difficulties applying this patch , now the
        PatchFluidPolyMono-0003.zip

        > file contains the full tree already patched.

        > https://sourceforge.net/p/fluidsynth/tickets/160/
        <https://sourceforge.net/p/fluidsynth/tickets/160/>

        >

        > That means that if you intend to try this patch you only need to

        > build the tree on your platform.

        >

        > As usual ,building steps are commands: cmake, make,...

        >

        > Regards

        > jjc

        >

        >

        >

            > Message du 06/08/16 00:30
            > > De : "Ceresa Jean-Jacques" <jean-jacques.cer...@orange.fr>
            > > A : "FluidSynth mailing list" <fluid-dev@nongnu.org>
            > > Copie à :
            > > Objet : Re: [fluid-dev] New Patch - polymono -
            functionality
            > >
            > >

            > > Hi, Ben

            > >

            > > Please, have you try the command without --binary option ?

            > >

            > > patch -p2 < fluid-polymono-0003.patch

            > >

            > > jjc

            > >

            > >

                > Message du 05/08/16 23:01
                > > De : "Ben Gonzales" <b...@gonzos.net>
                > > A : fluid-dev@nongnu.org
                > > Copie à :
                > > Objet : Re: [fluid-dev] New Patch - polymono -
                functionality
                > >
                > > Hi JJ.
                > >
                > > I tried the -p2 option before. It produced the
                same result as the -p1
                > >
                > > I think the issue is that on windows the file
                names look like this:
                > >
                > > ./fluidsynth-1.1.6\include\fluidsynth\synth.h
                > >
                > > but *nix needs the slashes to go the other way ( /
                ) like this:
                > >
                > > ./fluidsynth-1.1.6/include/fluidsynth/synth.h
                > >
                > > I looked at RL Horn's patch and that's what it was
                like.
                > >
                > > Ben
                > >
                > >
                > >
                On 05/08/16 21:35, jean-jacques.ceresa wrote:
                > >

                    Hi, Ben
                    > >
                    > > There are typos errors in the manual , i'am sorry
                    > >
                    > > 1) the -p options must be -p2.
                    > > 2) the --binary is necessary only when
                    patching on Windows environnement from a patch coming
                    > >   from unix. In your case the situation is the
                    reverse.
                    > >
                    > > On my platform (Windows) executing the
                    command: patch -p2 < fluid-polymono-0003.patch, works
                    > >
                    > > So please try :
                    > >
                    > > So after
                    > >  - reading section 1.1.3 and
                    > >  - renaming the "fluidsynth" directory to
                    "fluidsynth-1.1.6" is not necessary (as far we use
                    -p options)
                    > >  - putting the patch file into the directory, then
                    > >  - moving to the directory, then run
                    > >
                    > >  patch -p2 < fluid-polymono-0003.patch
                    > >
                    > > I hope it will work. If it is not the case, i
                    will send the full tree already patched.
                    > >
                    > > jjc
                    > >
                    > >
                    Le 05/08/2016 09:32, Ben Gonzales a écrit :
                    > >

                        Nope, didn't work..
                        > >
                        > > Perhaps the slashes are the wrong way for
                        a *nix environment?
                        > >
                        > > Ben
                        > >
                        > >
                        On 05/08/16 16:25, Kjetil Matheussen wrote:
                        > >

                            Hi,

                            > >
                            Seems like you need to use a different -p
                            option, as the
                            error message suggests. Maybe -p2 or -p0
                            will work instead of -p1.

                            > >
                            On Fri, Aug 5, 2016 at 8:18 AM, Ben
                            Gonzales <b...@gonzos.net> wrote:
                            > >

                                Yes, sorry. The phrase "Read the
                                manual" comes to mind...
                                > >
                                > > So after
                                > > - reading section 1.1.3 and
                                > > - renaming the "fluidsynth"
                                directory to "fluidsynth-1.1.6", then
                                > > - putting the patch file into the
                                directory, then
                                > > - moving to the directory, then
                                > > - issuing the patch command, I got:
                                > >
                                > > pi@ewipi:~/fluidsynth-1.1.6 $
                                patch -p1 --binary <
                                fluid-polymono-0003.patch
                                > > can't find file to patch at input
                                line 4
                                > > Perhaps you used the wrong -p or
                                --strip option?
                                > > The text leading up to this was:
                                > > --------------------------
                                > > |diff -Naur
                                ./fluidsynth-1.1.6\include\fluidsynth\synth.h
                                ./fluid-polymono-0003\include\fluidsynth\synth.h
                                > > |---
                                ./fluidsynth-1.1.6\include\fluidsynth\synth.h
                                  Tue May 19 12:27:02 2015
                                > > |+++
                                ./fluid-polymono-0003\include\fluidsynth\synth.h
                                  Sun Jul 31 15:49:44 2016
                                > > --------------------------
                                > > File to patch: ^C
                                > >
                                > >
                                > > It can't find the file to patch.
                                > >
                                > > Ben

                                > >
                                > >
                                > > On 04/08/16 19:54,
                                jean-jacques.ceresa wrote:
                                > >

                                    Hi Ben,
                                    > > >To compile this patch, do I
                                    have to start from a base version
                                    of FS and then apply patch 3?
                                    > > Yes, has explained in the the
                                    pdf (chapter 'how to apply this
                                    path'), one need to start from FS
                                    version 1.1.6 git.
                                    > >
                                    > > 1) apply the patch as
                                    described in the pdf. The
                                    procedure is the same as for
                                    previous patch.
                                    > > 2) cmake than make. Anyway ,
                                    always look at the result of the
                                    make and verify that the library
                                    (libfluidsynth.so)
                                    > > is build without errors. Only
                                    the library is concerned by this
                                    patch.
                                    > >
                                    > > To give you a quick try, you
                                    can run the tutorial commands
                                    files at the console. Please read
                                    tutorials (part 2).
                                    > >
                                    > > >If I have applied the first
                                    patch, can I then apply patch3?
                                    > > No, you cannot because this
                                    patch supersedes all previous patches.
                                    > >
                                    > > regards
                                    > >
                                    > > jjc
                                    > >
                                    > > Le 04/08/2016 09:01, Ben
                                    Gonzales a écrit :
                                    > >

                                        Hi Jean-Jacques.
                                        > >
                                        > > To compile this patch, do
                                        I have to start from a base
                                        version of FS and then apply
                                        patch 3? If I have applied the
                                        first patch, can I then apply
                                        patch3?
                                        > >
                                        > > Ben
                                        > >
                                        > > On 04/08/16 01:04,
                                        jean-jacques.ceresa wrote:
                                        > >

                                            Hi, Fluidsynth users
                                            > >
                                            > > Regardless the
                                            instruments you like to
                                            play (monophonic or
                                            polyphonic),
                                            > > enhancements
                                            functionalities have be
                                            done for both.
                                            > > You will find this on
                                            
https://sourceforge.net/p/fluidsynth/tickets/160/
                                            
<https://sourceforge.net/p/fluidsynth/tickets/160/>
                                            > >
                                            > > Best regards.
                                            > >
                                            > > jjc
                                            > >
                                            > >
                                            > >
                                            > >
                                            > >
                                            > >
                                            
_______________________________________________
                                            > > fluid-dev mailing list
                                            > > fluid-dev@nongnu.org
                                            <mailto:fluid-dev@nongnu.org>
                                            > >
                                            
https://lists.nongnu.org/mailman/listinfo/fluid-dev
                                            > >


                                        > >
                                        > >
                                        
_______________________________________________
                                        > > fluid-dev mailing list
                                        > > fluid-dev@nongnu.org
                                        <mailto:fluid-dev@nongnu.org>
                                        > >
                                        
https://lists.nongnu.org/mailman/listinfo/fluid-dev
                                        > >


                                    > >
                                    > >
                                    
_______________________________________________
                                    > > fluid-dev mailing list
                                    > > fluid-dev@nongnu.org
                                    <mailto:fluid-dev@nongnu.org>
                                    > >
                                    
https://lists.nongnu.org/mailman/listinfo/fluid-dev
                                    > >


                                > >
                                > >
                                _______________________________________________
                                > > fluid-dev mailing list
                                > > fluid-dev@nongnu.org
                                <mailto:fluid-dev@nongnu.org>
                                > >
                                
https://lists.nongnu.org/mailman/listinfo/fluid-dev
                                > >


                            > >

                            > >


                            > >

                            _______________________________________________
                            fluid-dev mailing list
                            fluid-dev@nongnu.org
                            https://lists.nongnu.org/mailman/listinfo/fluid-dev


                        > >
                        > >


                        > >

                        _______________________________________________
                        fluid-dev mailing list
                        fluid-dev@nongnu.org
                        https://lists.nongnu.org/mailman/listinfo/fluid-dev


                    > >
                    > >


                    > >

                    _______________________________________________
                    fluid-dev mailing list
                    fluid-dev@nongnu.org
                    https://lists.nongnu.org/mailman/listinfo/fluid-dev


                > >
                >
                >
                > _______________________________________________
                > fluid-dev mailing list
                > fluid-dev@nongnu.org
                > https://lists.nongnu.org/mailman/listinfo/fluid-dev
                >
                >


            >
            >
            > _______________________________________________
            > fluid-dev mailing list
            > fluid-dev@nongnu.org
            > https://lists.nongnu.org/mailman/listinfo/fluid-dev
            >
            >


        >


        >

        _______________________________________________
        fluid-dev mailing list
        fluid-dev@nongnu.org
        https://lists.nongnu.org/mailman/listinfo/fluid-dev


    >


    _______________________________________________
    fluid-dev mailing list
    fluid-dev@nongnu.org
    https://lists.nongnu.org/mailman/listinfo/fluid-dev

    >
    > [ fluid-polymono-0003.patch (159.3 Ko) ]



_______________________________________________
fluid-dev mailing list
fluid-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/fluid-dev

_______________________________________________
fluid-dev mailing list
fluid-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/fluid-dev

Reply via email to