[
https://issues.apache.org/jira/browse/FLUME-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186053#comment-13186053
]
Prasad Mujumdar commented on FLUME-923:
---------------------------------------
+1
Overall looks good
Few comments -
1) Please rebase the changes. Flume-932 has changed the way you register
sources/sinks. Now you don't need to register the sink in Application.java
2)JMSSink.java and TestJMSSink.java - Change tabs to space (ts=2)
3) We follow code review for any large patch, so please submit it via review
board. I will approve it and commit it to ng branch.
4) Does the test need ActiveMQ installed/configured manually before test run ?
5) JMSSink.java ::process() : In the exception handler code, the jmsSession
could be null if the createConnection() fail. It would be better to add a null
check before jmsSession.rollback().
6) JMSSink.java ::process() : Change the counter name from event.irc to
event.jms or something like that ...
> Implement a JMS sink for Flume NG
> ---------------------------------
>
> Key: FLUME-923
> URL: https://issues.apache.org/jira/browse/FLUME-923
> Project: Flume
> Issue Type: New Feature
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-923-2.patch, FLUME-923-3.patch, FLUME-923.patch,
> jms.conf
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
