[
https://issues.apache.org/jira/browse/FLUME-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186750#comment-13186750
]
[email protected] commented on FLUME-923:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3505/#review4392
-----------------------------------------------------------
Some nits, but otherwise looks good! Thanks Bruno!
flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java
<https://reviews.apache.org/r/3505/#comment9895>
nit: trailing space.
flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java
<https://reviews.apache.org/r/3505/#comment9886>
style nit: no need to qualify logger.
flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java
<https://reviews.apache.org/r/3505/#comment9887>
nit: Rogue tab character.
flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java
<https://reviews.apache.org/r/3505/#comment9888>
nit: tab.
flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java
<https://reviews.apache.org/r/3505/#comment9890>
style: indent.
flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java
<https://reviews.apache.org/r/3505/#comment9889>
style: indent.
flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java
<https://reviews.apache.org/r/3505/#comment9891>
nit: tab.
flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java
<https://reviews.apache.org/r/3505/#comment9892>
nit: tab.
flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java
<https://reviews.apache.org/r/3505/#comment9893>
nit: tab.
flume-ng-sinks/flume-jms-sink/src/test/java/org/apache/flume/sink/jms/TestJMSSink.java
<https://reviews.apache.org/r/3505/#comment9894>
nit: double newline and space.
pom.xml
<https://reviews.apache.org/r/3505/#comment9896>
I wonder what we should do about plugins going forward. Obviously each
plugin has its own deps but we don't necessarily want people to have to deal
with a lot of bloat for features they'll never use. This is fine for now, but
we should start a FEP or something to figure it out.
- Eric
On 2012-01-14 05:47:18, Bruno Mahé wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3505/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-14 05:47:18)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add an implementation for a JMS sink
bq.
bq.
bq. This addresses bug FLUME-923.
bq. https://issues.apache.org/jira/browse/FLUME-923
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 5be602a
bq. flume-ng-dist/pom.xml 5c20252
bq. flume-ng-node/pom.xml c0e295c
bq. flume-ng-sinks/flume-jms-sink/pom.xml PRE-CREATION
bq.
flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java
PRE-CREATION
bq.
flume-ng-sinks/flume-jms-sink/src/test/java/org/apache/flume/sink/jms/TestJMSSink.java
PRE-CREATION
bq. flume-ng-sinks/pom.xml 044bf8e
bq. pom.xml 6002358
bq.
bq. Diff: https://reviews.apache.org/r/3505/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Checked unit tests pass, including the one from the JMS sink
bq. * Brought up my own external JMS broker and hooked up a JMS sink on a
flume node
bq.
bq.
bq. Thanks,
bq.
bq. Bruno
bq.
bq.
> Implement a JMS sink for Flume NG
> ---------------------------------
>
> Key: FLUME-923
> URL: https://issues.apache.org/jira/browse/FLUME-923
> Project: Flume
> Issue Type: New Feature
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-923-01-13-2.patch, FLUME-923-2.patch,
> FLUME-923-3.patch, FLUME-923.patch, jms.conf
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
