[
https://issues.apache.org/jira/browse/FLUME-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187174#comment-13187174
]
[email protected] commented on FLUME-923:
-----------------------------------------------------
bq. On 2012-01-16 07:28:36, Eric Sammer wrote:
bq. > pom.xml, lines 536-540
bq. > <https://reviews.apache.org/r/3505/diff/1/?file=68955#file68955line536>
bq. >
bq. > I wonder what we should do about plugins going forward. Obviously
each plugin has its own deps but we don't necessarily want people to have to
deal with a lot of bloat for features they'll never use. This is fine for now,
but we should start a FEP or something to figure it out.
I sort of see what you mean but I am not sure to follow.
This is in the dependencyManagement section and won't be pulled for any module
(unless I got maven wrong). And in this case it is only needed in a test scope
for the jms sink and therefore won't be included in the dist tarball or maven
module depending on the jms sink (so it's broker independent).
This makes me actually wonder if we should include a default broker in the dist
tarball so the jms sink can work out of the box? Otherwise users would have to
put the needed jar for their favourite broker in flume's classpath
- Bruno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3505/#review4392
-----------------------------------------------------------
On 2012-01-14 05:47:18, Bruno Mahé wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3505/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-14 05:47:18)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add an implementation for a JMS sink
bq.
bq.
bq. This addresses bug FLUME-923.
bq. https://issues.apache.org/jira/browse/FLUME-923
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 5be602a
bq. flume-ng-dist/pom.xml 5c20252
bq. flume-ng-node/pom.xml c0e295c
bq. flume-ng-sinks/flume-jms-sink/pom.xml PRE-CREATION
bq.
flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java
PRE-CREATION
bq.
flume-ng-sinks/flume-jms-sink/src/test/java/org/apache/flume/sink/jms/TestJMSSink.java
PRE-CREATION
bq. flume-ng-sinks/pom.xml 044bf8e
bq. pom.xml 6002358
bq.
bq. Diff: https://reviews.apache.org/r/3505/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Checked unit tests pass, including the one from the JMS sink
bq. * Brought up my own external JMS broker and hooked up a JMS sink on a
flume node
bq.
bq.
bq. Thanks,
bq.
bq. Bruno
bq.
bq.
> Implement a JMS sink for Flume NG
> ---------------------------------
>
> Key: FLUME-923
> URL: https://issues.apache.org/jira/browse/FLUME-923
> Project: Flume
> Issue Type: New Feature
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-923-01-13-2.patch, FLUME-923-2.patch,
> FLUME-923-3.patch, FLUME-923.patch, jms.conf
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
