[
https://issues.apache.org/jira/browse/FLUME-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213176#comment-13213176
]
[email protected] commented on FLUME-984:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3980/
-----------------------------------------------------------
(Updated 2012-02-22 01:26:59.240182)
Review request for Flume.
Changes
-------
Updated diff based on feedback. Now if Sink throws a
FlumePermanentFailureException the SinkRunner will terminate.
Summary
-------
Catches, logs, and sleeps when a general exception occurs. This is similar to
PollingSourceRunner.
This addresses bug FLUME-984.
https://issues.apache.org/jira/browse/FLUME-984
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/FlumePermanentFailureException.java
PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java 9e46d87
Diff: https://reviews.apache.org/r/3980/diff
Testing
-------
All unit tests pass.
Thanks,
Brock
> SinkRunner should catch unhanded exceptions and log them like
> PollingSourceRunner
> ---------------------------------------------------------------------------------
>
> Key: FLUME-984
> URL: https://issues.apache.org/jira/browse/FLUME-984
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-984-0.patch, FLUME-984-1.patch
>
>
> If a Sink throws any exception but EventDeliveryException the sink will die.
> We should catch the exception, perhaps backoff a bit, and retry like
> PollingSourceRunner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
